what do you mean it's not tidally locked??? (#22554)

Author: SapphicOverload

code/__DEFINES/sound.dm

@@ -48,6 +48,7 @@
 #define AMBIENCE_RUINS "ruins"
 #define AMBIENCE_ENGI "engi"
 #define AMBIENCE_MINING "mining"
+#define AMBIENCE_JUNGLE "jungle"
 #define AMBIENCE_MEDICAL "med"
 #define AMBIENCE_SPOOKY "spooky"
 #define AMBIENCE_SPACE "space"

code/__HELPERS/time.dm

@@ -12,7 +12,7 @@
 	return time2text(wtime - GLOB.timezoneOffset, format)
 
 /proc/station_time(display_only = FALSE, wtime=world.time)
-	return ((((wtime - SSticker.round_start_time) * SSticker.station_time_rate_multiplier) + SSticker.gametime_offset) % 864000) - (display_only? GLOB.timezoneOffset : 0)
+	return ((((wtime - SSticker.round_start_time) * SSticker.station_time_rate_multiplier) + SSticker.gametime_offset) % MIDNIGHT_ROLLOVER) - (display_only? GLOB.timezoneOffset : 0)
 
 /proc/station_time_timestamp(format = "hh:mm:ss", wtime)
 	return time2text(station_time(TRUE, wtime), format)
@@ -21,7 +21,7 @@
 	if(isnum(force_set))
 		SSticker.gametime_offset = force_set
 		return
-	SSticker.gametime_offset = rand(0, 864000)		//hours in day * minutes in hour * seconds in minute * deciseconds in second
+	SSticker.gametime_offset = rand(0, MIDNIGHT_ROLLOVER)		//hours in day * minutes in hour * seconds in minute * deciseconds in second
 	if(prob(50))
 		SSticker.gametime_offset = FLOOR(SSticker.gametime_offset, 3600)
 	else

code/controllers/subsystem/daylight.dm

@@ -0,0 +1,20 @@
+SUBSYSTEM_DEF(daylight)
+	name = "Daylight"
+	wait = 2 SECONDS
+	/// Time required to complete a full day-night cycle
+	var/daylight_time = 24 MINUTES
+	/// All areas that should update their lighting based on time of day
+	var/list/area/daylight_areas = list()
+
+/datum/controller/subsystem/daylight/proc/add_lit_area(area/new_area)
+	daylight_areas.Add(new_area)
+
+/datum/controller/subsystem/daylight/proc/remove_lit_area(area/old_area)
+	daylight_areas.Remove(old_area)
+
+/datum/controller/subsystem/daylight/fire(resumed = FALSE)
+	var/light_coefficient = max((sin(world.time * 360 / daylight_time) + 0.5) * 2 / 3, 0)
+	var/light_alpha = round(255 * light_coefficient)
+	var/light_color = rgb(255, 130 + 125 * light_coefficient, 130 + 125 * light_coefficient)
+	for(var/area/lit_area as anything in daylight_areas)
+		lit_area.set_base_lighting(light_color, light_alpha)

code/datums/mapgen/dungeon_generators/generator_theme.dm

@@ -127,6 +127,7 @@
 		/obj/structure/flora/ausbushes/ywflowers = 1,
 		/obj/structure/flora/ausbushes/ppflowers = 1,
 		/obj/structure/flora/ausbushes/fullgrass = 1,
+		/obj/structure/herb/lantern = 1,
 	)
 
 	weighted_openfloor_spawn_list = list(
@@ -149,7 +150,8 @@
 		/obj/structure/flora/ausbushes/lavendergrass = 1,
 		/obj/structure/flora/ausbushes/ywflowers = 1,
 		/obj/structure/flora/ausbushes/ppflowers = 1,
-		/obj/structure/flora/ausbushes/fullgrass = 1
+		/obj/structure/flora/ausbushes/fullgrass = 1,
+		/obj/structure/herb/lantern = 1,
 		)
 
 /turf/open/floor/plating/dirt/jungleland/backrooms //fullbright backrooms? in this economy?

code/game/area/areas.dm

@@ -136,6 +136,8 @@
 	/// Whether the lights in this area aren't turned off when it's empty at roundstart
 	var/lights_always_start_on = FALSE
 
+	/// Whether to cycle brightness based on time of day
+	var/uses_daylight = FALSE
 
 /**
   * A list of teleport locations
@@ -185,6 +187,8 @@ GLOBAL_LIST_EMPTY(teleportlocs)
 	if (unique)
 		GLOB.areas_by_type[type] = src
 	GLOB.areas += src
+	if(uses_daylight)
+		SSdaylight.add_lit_area(src)
 	return ..()
 
 /**
@@ -381,6 +385,9 @@ GLOBAL_LIST_EMPTY(teleportlocs)
 	if(!isnull(GLOB.delta_areas))
 		GLOB.delta_areas -= src
 
+	//daylight cleanup
+	if(uses_daylight)
+		SSdaylight.remove_lit_area(src)
 	//machinery cleanup
 	STOP_PROCESSING(SSobj, src)
 	//turf cleanup

code/modules/holiday/holidays.dm

@@ -654,7 +654,7 @@ Since Ramadan is an entire month that lasts 29.5 days on average, the start and
 */
 
 /datum/holiday/ramadan/shouldCelebrate(dd, mm, yy, ww, ddd)
-	return (round(((world.realtime - 285984000) / 864000) % 354.373435326843) == 0)
+	return (round(((world.realtime - 285984000) / MIDNIGHT_ROLLOVER) % 354.373435326843) == 0)
 
 /datum/holiday/ramadan/getStationPrefix()
 	return pick("Harm","Halaal","Jihad","Muslim")
@@ -663,7 +663,7 @@ Since Ramadan is an entire month that lasts 29.5 days on average, the start and
 	name = "End of Ramadan"
 
 /datum/holiday/ramadan/end/shouldCelebrate(dd, mm, yy, ww, ddd)
-	return (round(((world.realtime - 312768000) / 864000) % 354.373435326843) == 0)
+	return (round(((world.realtime - 312768000) / MIDNIGHT_ROLLOVER) % 354.373435326843) == 0)
 
 /datum/holiday/lifeday
 	name = "Life Day"

icons/obj/hydroponics/growing_fruits.dmi

@@ -420,6 +420,7 @@
 #include "code\controllers\subsystem\callback.dm"
 #include "code\controllers\subsystem\chat.dm"
 #include "code\controllers\subsystem\communications.dm"
+#include "code\controllers\subsystem\daylight.dm"
 #include "code\controllers\subsystem\dbcore.dm"
 #include "code\controllers\subsystem\dcs.dm"
 #include "code\controllers\subsystem\demo.dm"

yogstation.dme

@@ -94,7 +94,8 @@
 		/obj/structure/flora/rock/pile = 20,
 		/obj/structure/flora/stump = 20,
 		/obj/structure/flora/tree/jungle = 10,
-		/obj/structure/herb/cinchona = 1, 
+		/obj/structure/herb/lantern = 2,
+		/obj/structure/herb/cinchona = 1,
 		/obj/structure/flytrap = 1
 		)
 	loose_flora_density = 10
@@ -207,6 +208,7 @@
 		/obj/structure/flora/ausbushes/leafybush = 20,
 		/obj/structure/flora/ausbushes/sparsegrass = 20,
 		/obj/structure/flora/ausbushes/fullgrass = 20,
+		/obj/structure/herb/lantern = 3,
 		/obj/structure/herb/fruit = 4,
 		/obj/structure/flytrap = 2,
 		/obj/structure/herb/explosive_shrooms = 1

yogstation/code/datums/mapgen/biomes/JungleBiomes.dm

@@ -1,7 +1,6 @@
 /area/ruin/unpowered/ivymen
 	icon_state = "red"
-	static_lighting = FALSE
-	base_lighting_alpha = 255
+	uses_daylight = TRUE
 
 /area/ruin/unpowered/tar_temple
 	icon_state = "red"