radio magic

Author: wonderinghost

code/game/machinery/bank_machine.dm

@@ -16,6 +16,7 @@
 	radio = new(src)
 	radio.subspace_transmission = TRUE
 	radio.canhear_range = 0
+	radio.set_listening(FALSE)
 	radio.recalculateChannels()
 
 /obj/machinery/computer/bank_machine/Destroy()

code/game/machinery/doors/brigdoors.dm

@@ -83,7 +83,7 @@
 	. = ..()
 
 	Radio = new/obj/item/radio(src)
-	Radio.listening = 0
+	Radio.set_listening(FALSE)
 
 /obj/machinery/door_timer/Initialize(mapload)
 	. = ..()

code/game/machinery/hologram.dm

@@ -1,3 +1,8 @@
+#define CAN_HEAR_MASTERS (1<<0)
+#define CAN_HEAR_ACTIVE_HOLOCALLS (1<<1)
+#define CAN_HEAR_RECORD_MODE (1<<2)
+#define CAN_HEAR_ALL_FLAGS (CAN_HEAR_MASTERS|CAN_HEAR_ACTIVE_HOLOCALLS|CAN_HEAR_RECORD_MODE)
+
 /* Holograms!
  * Contains:
  *		Holopad
@@ -42,7 +47,8 @@ GLOBAL_LIST_EMPTY(holopads)
 	max_integrity = 300
 	armor = list(MELEE = 50, BULLET = 20, LASER = 20, ENERGY = 20, BOMB = 0, BIO = 0, RAD = 0, FIRE = 50, ACID = 0)
 	circuit = /obj/item/circuitboard/machine/holopad
-	/// List of living mobs that use the holopad
+	/// associative lazylist of the form: list(mob calling us = hologram representing that mob).
+	/// this is only populated for holopads answering calls from another holopad
 	var/list/masters
 	/// Holoray-mob link
 	var/list/holorays
@@ -83,10 +89,8 @@ GLOBAL_LIST_EMPTY(holopads)
 	var/padname = null
 	/// Holopad Harassment Cooldown
 	var/holopad_cooldown = 20 SECONDS
-
-/obj/machinery/holopad/Initialize()
-	. = ..()
-	become_hearing_sensitive()
+	///bitfield. used to turn on and off hearing sensitivity depending on if we can act on Hear() at all - meant for lowering the number of unessesary hearable atoms
+	var/can_hear_flags = NONE
 
 /obj/machinery/holopad/secure
 	name = "secure holopad"
@@ -156,9 +160,8 @@ obj/machinery/holopad/secure/Initialize(mapload)
 	if(outgoing_call)
 		outgoing_call.ConnectionFailure(src)
 
-	for(var/I in holo_calls)
-		var/datum/holocall/HC = I
-		HC.ConnectionFailure(src)
+	for(var/datum/holocall/holocall_to_disconnect as anything in holo_calls)
+		holocall_to_disconnect.ConnectionFailure(src)
 
 	for (var/I in masters)
 		clear_holo(I)
@@ -360,13 +363,59 @@ obj/machinery/holopad/secure/Initialize(mapload)
 				outgoing_call.Disconnect(src)
 				return TRUE
 
+
+//setters
+/**
+ * setter for can_hear_flags. handles adding or removing the given flag on can_hear_flags and then adding hearing sensitivity or removing it depending on the final state
+ * this is necessary because holopads are a significant fraction of the hearable atoms on station which increases the cost of procs that iterate through hearables
+ * so we need holopads to not be hearable until it is needed
+ *
+ * * flag - one of the can_hear_flags flag defines
+ * * set_flag - boolean, if TRUE sets can_hear_flags to that flag and might add hearing sensitivity if can_hear_flags was NONE before,
+ * if FALSE unsets the flag and possibly removes hearing sensitivity
+ */
+/obj/machinery/holopad/proc/set_can_hear_flags(flag, set_flag = TRUE)
+	if(!(flag & CAN_HEAR_ALL_FLAGS))
+		return FALSE //the given flag doesnt exist
+
+	if(set_flag)
+		if(can_hear_flags == NONE)//we couldnt hear before, so become hearing sensitive
+			become_hearing_sensitive()
+
+		can_hear_flags |= flag
+		return TRUE
+
+	else
+		can_hear_flags &= ~flag
+		if(can_hear_flags == NONE)
+			lose_hearing_sensitivity()
+
+		return TRUE
+
+///setter for adding/removing holocalls to this holopad. used to update the holo_calls list and can_hear_flags
+///adds the given holocall if add_holocall is TRUE, removes if FALSE
+/obj/machinery/holopad/proc/set_holocall(datum/holocall/holocall_to_update, add_holocall = TRUE)
+	if(!istype(holocall_to_update))
+		return FALSE
+
+	if(add_holocall)
+		set_can_hear_flags(CAN_HEAR_ACTIVE_HOLOCALLS)
+		LAZYADD(holo_calls, holocall_to_update)
+
+	else
+		LAZYREMOVE(holo_calls, holocall_to_update)
+		if(!LAZYLEN(holo_calls))
+			set_can_hear_flags(CAN_HEAR_ACTIVE_HOLOCALLS, FALSE)
+
+	return TRUE
+
+
 /**
   * hangup_all_calls: Disconnects all current holocalls from the holopad
   */
 /obj/machinery/holopad/proc/hangup_all_calls()
-	for(var/I in holo_calls)
-		var/datum/holocall/HC = I
-		HC.Disconnect(src)
+	for(var/datum/holocall/holocall_to_disconnect as anything in holo_calls)
+		holocall_to_disconnect.Disconnect(src)
 
 //do not allow AIs to answer calls or people will use it to meta the AI sattelite
 /obj/machinery/holopad/attack_ai(mob/living/silicon/ai/user)
@@ -464,10 +513,12 @@ For the other part of the code, check silicon say.dm. Particularly robot talk.*/
 			if(masters[master] && speaker != master)
 				master.relay_speech(message, speaker, message_language, raw_message, radio_freq, spans, message_mods)
 
-	for(var/I in holo_calls)
-		var/datum/holocall/HC = I
-		if(HC.connected_holopad == src && speaker != HC.hologram)
-			HC.user.Hear(message, speaker, message_language, raw_message, radio_freq, spans, message_mods)
+	for(var/datum/holocall/holocall_to_update as anything in holo_calls)
+		if(holocall_to_update.connected_holopad == src)//if we answered this call originating from another holopad
+			if(speaker == holocall_to_update.hologram && holocall_to_update.user.client?.prefs.read_preference(/datum/preference/toggle/enable_runechat))
+				holocall_to_update.user.create_chat_message(speaker, message_language, raw_message, spans)
+			else
+				holocall_to_update.user.Hear(message, speaker, message_language, raw_message, radio_freq, spans, message_mods)
 
 	if(outgoing_call && speaker == outgoing_call.user)
 		outgoing_call.hologram.say(raw_message)
@@ -498,6 +549,7 @@ For the other part of the code, check silicon say.dm. Particularly robot talk.*/
 /obj/machinery/holopad/proc/set_holo(mob/living/user, obj/effect/overlay/holo_pad_hologram/h)
 	LAZYSET(masters, user, h)
 	LAZYSET(holorays, user, new /obj/effect/overlay/holoray(loc))
+	set_can_hear_flags(CAN_HEAR_MASTERS)
 	var/mob/living/silicon/ai/AI = user
 	if(istype(AI))
 		AI.current = src
@@ -518,6 +570,8 @@ For the other part of the code, check silicon say.dm. Particularly robot talk.*/
 	if(istype(AI) && AI.current == src)
 		AI.current = null
 	LAZYREMOVE(masters, user) // Discard AI from the list of those who use holopad
+	if(!LAZYLEN(masters))
+		set_can_hear_flags(CAN_HEAR_MASTERS, set_flag = FALSE)
 	qdel(holorays[user])
 	LAZYREMOVE(holorays, user)
 	SetLightsAndPower()
@@ -637,6 +691,7 @@ For the other part of the code, check silicon say.dm. Particularly robot talk.*/
 		return
 	disk.record = new
 	record_mode = TRUE
+	set_can_hear_flags(CAN_HEAR_RECORD_MODE)
 	record_start = world.time
 	record_user = user
 	disk.record.set_caller_image(user)
@@ -706,6 +761,7 @@ For the other part of the code, check silicon say.dm. Particularly robot talk.*/
 	if(record_mode)
 		record_mode = FALSE
 		record_user = null
+		set_can_hear_flags(CAN_HEAR_RECORD_MODE, FALSE)
 
 /obj/machinery/holopad/proc/record_clear()
 	if(disk && disk.record)
@@ -748,3 +804,7 @@ For the other part of the code, check silicon say.dm. Particularly robot talk.*/
 
 #undef HOLOPAD_PASSIVE_POWER_USAGE
 #undef HOLOGRAM_POWER_USAGE
+#undef CAN_HEAR_MASTERS
+#undef CAN_HEAR_ACTIVE_HOLOCALLS
+#undef CAN_HEAR_RECORD_MODE
+#undef CAN_HEAR_ALL_FLAGS

code/game/machinery/requests_console.dm

@@ -115,7 +115,7 @@ GLOBAL_LIST_EMPTY(req_console_ckey_departments)
 	GLOB.req_console_ckey_departments[ckey(department)] = department
 
 	Radio = new /obj/item/radio(src)
-	Radio.listening = 0
+	Radio.set_listening(FALSE)
 
 /obj/machinery/requests_console/Destroy()
 	QDEL_NULL(Radio)

code/game/machinery/telecomms/broadcasting.dm

@@ -146,40 +146,48 @@
 	if(compression > 0)
 		message = Gibberish(message, compression + 40)
 
+	var/list/signal_reaches_every_z_level = levels
+
+	if(0 in levels)
+		signal_reaches_every_z_level = RADIO_NO_Z_LEVEL_RESTRICTION
+
 	// Assemble the list of radios
 	var/list/radios = list()
 	switch (transmission_method)
 		if (TRANSMISSION_SUBSPACE)
 			// Reaches any radios on the levels
-			for(var/obj/item/radio/R in GLOB.all_radios["[frequency]"])
-				if(R.can_receive(frequency, levels))
-					radios += R
+			var/list/all_radios_of_our_frequency = GLOB.all_radios["[frequency]"]
+			radios = all_radios_of_our_frequency.Copy()
+
+			for(var/obj/item/radio/subspace_radio in radios)
+				if(!subspace_radio.can_receive(frequency, signal_reaches_every_z_level))
+					radios -= subspace_radio
 
 			// Syndicate radios can hear all well-known radio channels
 			if (num2text(frequency) in GLOB.reverseradiochannels)
-				for(var/obj/item/radio/R in GLOB.all_radios["[FREQ_SYNDICATE]"])
-					if(R.can_receive(FREQ_SYNDICATE, list(R.z)))
-						radios |= R
+				for(var/obj/item/radio/syndicate_radios in GLOB.all_radios["[FREQ_SYNDICATE]"])
+					if(syndicate_radios.can_receive(FREQ_SYNDICATE, RADIO_NO_Z_LEVEL_RESTRICTION))
+						radios |= syndicate_radios
 
 		if (TRANSMISSION_RADIO)
 			// Only radios not currently in subspace mode
-			for(var/obj/item/radio/R in GLOB.all_radios["[frequency]"])
-				if(!R.subspace_transmission && R.can_receive(frequency, levels))
-					radios += R
+			for(var/obj/item/radio/non_subspace_radio in GLOB.all_radios["[frequency]"])
+				if(!non_subspace_radio.subspace_transmission && non_subspace_radio.can_receive(frequency, levels))
+					radios += non_subspace_radio
 
 		if (TRANSMISSION_SUPERSPACE)
 			// Only radios which are independent
-			for(var/obj/item/radio/R in GLOB.all_radios["[frequency]"])
-				if(R.independent && R.can_receive(frequency, levels))
-					radios += R
+			for(var/obj/item/radio/independent_radio in GLOB.all_radios["[frequency]"])
+				if(independent_radio.independent && independent_radio.can_receive(frequency, levels))
+					radios += independent_radio
 
 	// From the list of radios, find all mobs who can hear those.
-	var/list/receive = get_mobs_in_radio_ranges(radios)
+	var/list/receive = get_hearers_in_radio_ranges(radios)
 
 	// Cut out mobs with clients who are admins and have radio chatter disabled.
-	for(var/mob/R in receive)
-		if (R.client && R.client.holder && !(R.client.prefs.chat_toggles & CHAT_RADIO))
-			receive -= R
+	for(var/mob/dead/observer/ghost in GLOB.player_list)
+		if(ghost.client.prefs?.chat_toggles & CHAT_GHOSTRADIO)
+			receive |= ghost
 
 	// Add observers who have ghost radio enabled.
 	for(var/mob/dead/observer/M in GLOB.player_list)
@@ -191,7 +199,10 @@
 	var/spans = data["spans"]
 	var/list/message_mods = data["mods"]
 	var/rendered = virt.compose_message(virt, language, message, frequency, spans)
-	for(var/atom/movable/hearer in receive)
+	for(var/atom/movable/hearer as anything in receive)
+		if(!hearer)
+			stack_trace("null found in the hearers list returned by the spatial grid. this is bad")
+			continue
 		hearer.Hear(rendered, virt, language, message, frequency, spans, message_mods)
 
 	// This following recording is intended for research and feedback in the use of department radio channels
@@ -209,7 +220,7 @@
 	var/log_text = "\[[get_radio_name(frequency)]\] [spans_part]\"[message]\" (language: [lang_name])"
 
 	var/mob/source_mob = virt.source
-	if(istype(source_mob))
+	if(ismob(source_mob))
 		source_mob.log_message(log_text, LOG_TELECOMMS)
 	else
 		log_telecomms("[virt.source] [log_text] [loc_name(get_turf(virt.source))]")

code/game/machinery/telecomms/machine_interactions.dm

@@ -116,7 +116,7 @@
 					return
 				else
 					for(var/obj/machinery/telecomms/T in links)
-						T.links.Remove(src)
+						remove_link(T)
 					network = params["value"]
 					links = list()
 					log_game("[key_name(operator)] has changed the network for [src] at [AREACOORD(src)] to [network].")
@@ -141,22 +141,12 @@
 		if("unlink")
 			var/obj/machinery/telecomms/T = links[text2num(params["value"])]
 			if(T)
-				// Remove link entries from both T and src.
-				if(T.links)
-					T.links.Remove(src)
-				links.Remove(T)
-				log_game("[key_name(operator)] unlinked [src] and [T] at [AREACOORD(src)].")
-				. = TRUE
+				. = remove_link(T, operator)
+
 		if("link")
 			if(heldmultitool)
 				var/obj/machinery/telecomms/tcomms_machine = multitool_get_buffer(src, heldmultitool)
-				if(istype(tcomms_machine) && tcomms_machine != src)
-					if(!(src in tcomms_machine.links))
-						tcomms_machine.links += src
-					if(!(tcomms_machine in links))
-						links += tcomms_machine
-						log_game("[key_name(operator)] linked [src] for [tcomms_machine] at [AREACOORD(src)].")
-						. = TRUE
+				. = add_new_link(T, operator)
 		if("buffer") // Yogs start -- holotool support
 			if(heldmultitool)
 				multitool_set_buffer(usr, heldmultitool, src)
@@ -169,6 +159,42 @@
 	add_act(action, params)
 	. = TRUE
 
+///adds new_connection to src's links list AND vice versa. also updates links_by_telecomms_type
+/obj/machinery/telecomms/proc/add_new_link(obj/machinery/telecomms/new_connection, mob/user)
+	if(!istype(new_connection) || new_connection == src)
+		return FALSE
+
+	if((new_connection in links) && (src in new_connection.links))
+		return FALSE
+
+	links |= new_connection
+	new_connection.links |= src
+
+	LAZYADDASSOCLIST(links_by_telecomms_type, new_connection.telecomms_type, new_connection)
+	LAZYADDASSOCLIST(new_connection.links_by_telecomms_type, telecomms_type, src)
+
+	if(user)
+		log_game("[key_name(user)] linked [src] for [new_connection] at [AREACOORD(src)].")
+	return TRUE
+
+///removes old_connection from src's links list AND vice versa. also updates links_by_telecomms_type
+/obj/machinery/telecomms/proc/remove_link(obj/machinery/telecomms/old_connection, mob/user)
+	if(!istype(old_connection) || old_connection == src)
+		return FALSE
+
+	if(old_connection in links)
+		links -= old_connection
+		LAZYREMOVEASSOC(links_by_telecomms_type, old_connection.telecomms_type, old_connection)
+
+	if(src in old_connection.links)
+		old_connection.links -= src
+		LAZYREMOVEASSOC(old_connection.links_by_telecomms_type, telecomms_type, src)
+
+	if(user)
+		log_game("[key_name(user)] unlinked [src] and [old_connection] at [AREACOORD(src)].")
+
+	return TRUE
+
 /obj/machinery/telecomms/proc/add_option()
 	return
 

code/game/machinery/telecomms/machines/broadcaster.dm

@@ -12,6 +12,7 @@ GLOBAL_VAR_INIT(message_delay, 0) // To make sure restarting the recentmessages
 	name = "subspace broadcaster"
 	icon_state = "caster"
 	desc = "A dish-shaped machine used to broadcast processed subspace signals."
+	telecomms_type = /obj/machinery/telecomms/broadcaster
 	density = TRUE
 	use_power = IDLE_POWER_USE
 	idle_power_usage = 25

code/game/machinery/telecomms/machines/bus.dm

@@ -12,6 +12,7 @@
 	name = "bus mainframe"
 	icon_state = "bus"
 	desc = "A mighty piece of hardware used to send massive amounts of data quickly."
+	telecomms_type = /obj/machinery/telecomms/bus
 	density = TRUE
 	use_power = IDLE_POWER_USE
 	idle_power_usage = 50

code/game/machinery/telecomms/machines/hub.dm

@@ -12,6 +12,7 @@
 	name = "telecommunication hub"
 	icon_state = "hub"
 	desc = "A mighty piece of hardware used to send/receive massive amounts of data."
+	telecomms_type = /obj/machinery/telecomms/hub
 	density = TRUE
 	use_power = IDLE_POWER_USE
 	idle_power_usage = 80

code/game/machinery/telecomms/machines/message_server.dm

@@ -77,6 +77,7 @@
 	icon_state = "message_server"
 	name = "Messaging Server"
 	desc = "A machine that processes and routes PDA and request console messages."
+	telecomms_type = /obj/machinery/telecomms/message_server
 	density = TRUE
 	use_power = IDLE_POWER_USE
 	idle_power_usage = 10