Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Commit ca304a0

Browse files
fix (#22836)
1 parent 255004a commit ca304a0

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

code/datums/components/storage/storage.dm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ GLOBAL_LIST_EMPTY(cached_storage_typecaches)
239239
to_chat(M, span_notice("You failed to pick up anything with [parent]."))
240240
return
241241
var/list/rejections = list()
242-
while(do_after(M, 1 SECONDS, parent, TRUE, FALSE, CALLBACK(src, PROC_REF(handle_mass_pickup), things, I.loc, rejections)))
242+
while(do_after(M, 1 SECONDS, parent, NONE, TRUE, CALLBACK(src, PROC_REF(handle_mass_pickup), things, I.loc, rejections)))
243243
continue
244244
to_chat(M, span_notice("You put everything you could [insert_preposition] [parent]."))
245245

@@ -291,7 +291,7 @@ GLOBAL_LIST_EMPTY(cached_storage_typecaches)
291291
to_chat(M, span_notice("You start dumping out [parent]."))
292292
var/turf/T = get_turf(A)
293293
var/list/things = contents()
294-
while (do_after(M, 1 SECONDS, T, TRUE, FALSE, CALLBACK(src, PROC_REF(mass_remove_from_storage), T, things)))
294+
while (do_after(M, 1 SECONDS, T, NONE, TRUE, CALLBACK(src, PROC_REF(mass_remove_from_storage), T, things)))
295295
continue
296296

297297
/datum/component/storage/proc/mass_remove_from_storage(atom/target, list/things, trigger_on_found = TRUE)

code/datums/progressbar.dm

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
var/progress_ended = FALSE
2323

2424

25-
/datum/progressbar/New(mob/User, goal_number, atom/target, timed_action_flags = NONE)
25+
/datum/progressbar/New(mob/User, goal_number, atom/target, timed_action_flags = NONE, datum/callback/extra_checks)
2626
. = ..()
2727
if (!istype(target))
2828
stack_trace("Invalid target [target] passed in")
@@ -42,6 +42,7 @@
4242
SET_PLANE_EXPLICIT(bar, ABOVE_HUD_PLANE, User) //yogs change, increased so it draws ontop of ventcrawling overlays
4343
bar.appearance_flags = APPEARANCE_UI_IGNORE_ALPHA
4444
user = User
45+
src.extra_checks = extra_checks
4546

4647
LAZYADDASSOCLIST(user.progressbars, bar_loc, src)
4748
var/list/bars = user.progressbars[bar_loc]
@@ -59,7 +60,7 @@
5960
var/obj/mecha/mech = user.loc
6061
if(ismecha(user.loc) && user == mech.occupant)
6162
RegisterSignal(mech, COMSIG_MOVABLE_MOVED, PROC_REF(on_moved))
62-
if(!(timed_action_flags & IGNORE_TARGET_LOC_CHANGE))
63+
if(!(timed_action_flags & IGNORE_TARGET_LOC_CHANGE) && target != user)
6364
RegisterSignal(target, COMSIG_MOVABLE_MOVED, PROC_REF(on_moved))
6465
if(!(timed_action_flags & IGNORE_HELD_ITEM))
6566
var/obj/item/held = user.get_active_held_item()
@@ -70,6 +71,9 @@
7071
RegisterSignal(user, COMSIG_MOB_PICKUP_ITEM, PROC_REF(end_progress))
7172
RegisterSignal(user, COMSIG_MOB_SWAPPING_HANDS, PROC_REF(end_progress))
7273
if(!(timed_action_flags & IGNORE_INCAPACITATED))
74+
if(HAS_TRAIT(user, TRAIT_INCAPACITATED))
75+
end_progress()
76+
return
7377
RegisterSignal(user, SIGNAL_ADDTRAIT(TRAIT_INCAPACITATED), PROC_REF(end_progress))
7478

7579

0 commit comments

Comments
 (0)