Improvements + access copying

Author: Oblisk234

code/modules/mob/living/silicon/pai/pai.dm

@@ -272,7 +272,7 @@
 
 /mob/living/silicon/pai/examine(mob/user)
 	. = ..()
-	. += "A personal AI in holochassis mode. Its master ID string seems to be [master]."
+	. += "A personal AI in holochassis mode. Its master ID string seems to be [master ? master : "empty"]."
 	if(software && isobserver(user))
 		. += "<b>[src] has the following modules:"
 		for(var/list/module in software)
@@ -287,7 +287,7 @@
 			T.visible_message(span_warning("[src.cable] rapidly retracts back into its spool."), span_italics("You hear a click and the sound of wire spooling rapidly."))
 			qdel(src.cable)
 			cable = null
-			cable_status = "Retracted"
+			cable_status = PAI_CABLE_RETRACTED
 	silent = max(silent - 1, 0)
 	. = ..()
 
@@ -303,10 +303,21 @@
 /obj/item/computer_hardware/paicard/attackby(obj/item/W, mob/user, params)
 	. = ..()
 	user.set_machine(src)
-	if(pai.encryptmod == TRUE)
-		if(W.tool_behaviour == TOOL_SCREWDRIVER)
+	if(W.tool_behaviour == TOOL_SCREWDRIVER||istype(W, /obj/item/encryptionkey))
+		if(pai.encryptmod == TRUE)
 			pai.radio.attackby(W, user, params)
-		else if(istype(W, /obj/item/encryptionkey))
-			pai.radio.attackby(W, user, params)
-	else
-		to_chat(user, "Encryption Key ports not configured.")
+		else
+			to_chat(user, "Encryption Key ports not configured.")
+	else if(istype(W, /obj/item/card/id))
+		var/obj/item/card/id/id_card = W
+		pai.copy_access(id_card, user)
+
+/mob/living/silicon/pai/attackby(obj/item/W, mob/user, params)
+	. = ..()
+	if(istype(W, /obj/item/card/id))
+		var/obj/item/card/id/id_card = W
+		copy_access(id_card, user)
+
+/mob/living/silicon/pai/proc/copy_access(obj/item/card/id/ID, mob/user)
+	pai.access_card.access += ID.access
+	to_chat(user, "Copied access from [ID]!")

code/modules/mob/living/silicon/pai/software.dm

@@ -2,7 +2,8 @@
 //	- Potentially roll HUDs and Records into one
 //	- Shock collar/lock system for prisoner pAIs?
 //  - Camera jack
-
+#define PAI_CABLE_RETRACTED 0
+#define PAI_CABLE_EXTENDED 1
 
 /mob/living/silicon/pai/var/list/available_software = list(
 															//Nightvision
@@ -39,7 +40,7 @@
 /mob/living/silicon/pai/var/pressure
 /mob/living/silicon/pai/var/gases
 
-/mob/living/silicon/pai/var/cable_status = "Retracted"
+/mob/living/silicon/pai/var/cable_status = PAI_CABLE_RETRACTED
 
 /mob/living/silicon/pai/var/list/med_record = list()
 /mob/living/silicon/pai/var/list/sec_record = list()
@@ -94,7 +95,7 @@
 					qdel(new_record)
 					break
 	message_admins("Len: [med_record.len]")
-	message_admins("Record test: [med_record[0]")
+	message_admins("Record test: [med_record[0]]")
 	if(GLOB.data_core.general && GLOB.data_core.security)
 		sec_record = list()
 		for(var/datum/data/record/S in sortRecord(GLOB.data_core.security))
@@ -212,13 +213,15 @@
 				internal_instrument = new(src)
 			internal_instrument.interact(src)
 		if("cable")
+			if(cable_status == PAI_CABLE_EXTENDED)
+				return
 			var/turf/T = get_turf(loc)
 			cable = new /obj/item/pai_cable(T)
 			if(get(card, /mob/living/carbon/human))
 				var/mob/living/carbon/human/H = get(card, /mob/living/carbon/human)
 				H.put_in_hands(cable)
 			T.visible_message(span_warning("A port on [src] opens to reveal [cable], which promptly falls to the floor."), span_italics("You hear the soft click of something light and hard falling to the ground."))
-			cable_status = "Extended"
+			cable_status = PAI_CABLE_EXTENDED
 		if("jack")
 			if(cable && cable.machine)
 				hackdoor = cable.machine
@@ -231,7 +234,7 @@
 			qdel(cable)
 			hackdoor = null
 			cable = null
-			cable_status = "Retracted"
+			cable_status = PAI_CABLE_RETRACTED
 	update_appearance(UPDATE_ICON)
 
 /mob/living/silicon/pai/ui_state(mob/user)

tgui/packages/tgui/interfaces/PaiInterface.tsx

@@ -61,7 +61,7 @@ type Data = {
   temperature: number;
   hacking: boolean;
   hackprogress: number;
-  cable: string;
+  cable: boolean;
   door: string[];
   code: number;
   frequency: number;
@@ -381,17 +381,17 @@ const PaiBox = (props, context) => {
               maxValue={100}>
                 {AirlockJackTextSwitch(hackprogress)}
             </ProgressBar>
-            {cable === "Retracted" && (
+            {cable === false && (
               <Button onClick={() => act("cable")}>
                 Extend cable
               </Button>
             )}
-            {cable === "Extended" && (
+            {cable === true && (
               <Button onClick={() => act("retract")}>
                 Retract cable
               </Button>
             )}
-            {cable === "Extended" && door !== null && (
+            {cable === true && door !== null && (
               hacking ? (
                 <Button onClick={() => act("cancel")}>
                   Cancel Airlock Jack