I HATE THIS

JamieD1 · JamieD1 · commit 50e6290f00b6 · 2021-08-26T12:51:52.000+01:00
diff --git a/byond-extools/src/core/core.cpp b/byond-extools/src/core/core.cpp
@@ -124,11 +124,6 @@ unsigned int Core::GetStringId(std::string str, bool increment_refcount)
 	{
 		return GetStringTableIndexUTF8(str.c_str(), 0xFFFFFFFF, 0, 1);
 	}
-	else
-	{
-
-		break;
-	}
 	return 0;
 }
 
diff --git a/byond-extools/src/core/find_functions.cpp b/byond-extools/src/core/find_functions.cpp
@@ -103,13 +103,8 @@ bool Core::find_functions()
 	if (ByondVersion > 513)
 	{
 		FIND_OR_DIE(GetStringTableIndexUTF8, "55 8B EC 8B 45 ?? 83 EC ?? 53 56 8B 35 ?? ?? ?? ??");
-		break;
-	}
-	{
-		else break;
 	}
-	|
-		if (failed) return false;
+	if (failed) return false;
 	int offset = *(int *)((char *)TopicFloodCheck + 0x2C);
 	GetBSocket = (GetBSocketPtr)((char *)TopicFloodCheck + 0x2C + offset + 4); //done this way because pattern scanning would result in a different function
 

Original file line number	Diff line number	Diff line change
`@@ -124,11 +124,6 @@ unsigned int Core::GetStringId(std::string str, bool increment_refcount)`
`124`	`124`	`{`
`125`	`125`	`return GetStringTableIndexUTF8(str.c_str(), 0xFFFFFFFF, 0, 1);`
`126`	`126`	`}`
`127`		`- else`
`128`		`- {`
`129`		`-`
`130`		`- break;`
`131`		`- }`
`132`	`127`	`return 0;`
`133`	`128`	`}`
`134`	`129`
Original file line number	Diff line number	Diff line change
`@@ -103,13 +103,8 @@ bool Core::find_functions()`
`103`	`103`	`if (ByondVersion > 513)`
`104`	`104`	`{`
`105`	`105`	`FIND_OR_DIE(GetStringTableIndexUTF8, "55 8B EC 8B 45 ?? 83 EC ?? 53 56 8B 35 ?? ?? ?? ??");`
`106`		`- break;`
`107`		`- }`
`108`		`- {`
`109`		`- else break;`
`110`	`106`	`}`
`111`		`- \|`
`112`		`- if (failed) return false;`
	`107`	`+ if (failed) return false;`
`113`	`108`	`int offset = (int )((char *)TopicFloodCheck + 0x2C);`
`114`	`109`	`GetBSocket = (GetBSocketPtr)((char *)TopicFloodCheck + 0x2C + offset + 4); //done this way because pattern scanning would result in a different function`
`115`	`110`