eeeeee

Author: JamieD1

byond-extools/src/core/byond_structures.cpp

@@ -361,45 +361,24 @@ ManagedValue::~ManagedValue()
 
 Params MiscEntry::as_params()
 {
-	if (ByondVersion > 513 || ByondBuild >= 1539) {
 		return Params {
 			parameters2.count(),
 			parameters2.params,
 		};
 	}
 
-	return Params {
-		parameters1.count(),
-		parameters1.params,
-	};
-}
-
 LocalVars MiscEntry::as_locals()
 {
-	if (ByondVersion > 513 || ByondBuild >= 1539) {
 		return LocalVars {
 			local_vars2.count,
 			local_vars2.var_name_indices,
 		};
 	}
 
-	return LocalVars {
-		local_vars1.count,
-		local_vars1.var_name_indices,
-	};
-}
-
 ProcBytecode MiscEntry::as_bytecode()
 {
-	if (ByondVersion > 513 || ByondBuild >= 1539) {
 		return ProcBytecode {
 			bytecode2.bytecode_length,
 			&bytecode2.bytecode,
 		};
-	}
-
-	return ProcBytecode {
-		bytecode1.bytecode_length,
-		&bytecode1.bytecode,
-	};
 }

byond-extools/src/core/core.cpp

@@ -111,7 +111,7 @@ void Core::Alert(int what)
 }
 
 unsigned int Core::GetStringId(std::string str, bool increment_refcount) {
-	if (ByondVersion == 514) {
+	if (ByondVersion > 513) {
 		return GetStringTableIndexUTF8(str.c_str(), 0xFFFFFFFF, 0, 1);
 	}
 	return 0;

byond-extools/src/core/find_functions.cpp

@@ -117,7 +117,6 @@ bool Core::find_functions()
 	DecRefCount = (DecRefCountPtr)(x_ref_count_call + *(int *)x_ref_count_call + 4); //x_ref_count_call points to the relative offset to DecRefCount from the call site
 	x_ref_count_call = (char *)Pocket::Sigscan::FindPattern(BYONDCORE, "FF 75 10 E8 ?? ?? ?? ?? FF 75 0C 8B F8 FF 75 08 E8 ?? ?? ?? ?? 57", 17);
 	IncRefCount = (IncRefCountPtr)(x_ref_count_call + *(int *)x_ref_count_call + 4);
-
 	char *datum_inc_function = (char *)Pocket::Sigscan::FindPattern(BYONDCORE, "55 8b ec 8b 4d 08 3b 0d ?? ?? ?? ?? 73 11 a1 ?? ?? ?? ?? 8b 04 88 85 c0 74 05 ff 40 10 5d c3 6a");
 	datum_pointer_table_length = *(unsigned int **)(datum_inc_function + 8);
 	datum_pointer_table = *(RawDatum ****)(datum_inc_function + 15);