remove debug lines, remove unnecessary format proc, add procs to readme

Author: Chubbygummibear

README.md

@@ -88,6 +88,7 @@ To get additional features, pass a list to `--features`, for example `--features
 
 The default features are:
 * acreplace: Aho-Corasick string matching and replacement.
+* binary_space_partition: Function to generate "rooms" more or less evenly distributed over a given area.
 * cellularnoise: Function to generate cellular automata-based noise.
 * dmi: DMI manipulations which are impossible from within BYOND.
   Used by the asset cache subsystem to improve load times.
@@ -97,6 +98,7 @@ The default features are:
 * json: Function to check JSON validity.
 * log: Faster log output.
 * noise: 2d Perlin noise.
+* random_room_placement: Function to generate "rooms" randomly placed in a given area, only taking care to not overlap one another.
 * sql: Asynchronous MySQL/MariaDB client library.
 * time: High-accuracy time measuring.
 * toml: TOML parser.

src/binary_space_partition.rs

@@ -1,5 +1,4 @@
 use std::{fmt, cmp};
-use std::fmt::Write;
 use rand::distributions::WeightedIndex;
 use rand::prelude::*;
 use rand::rngs::StdRng;
@@ -16,11 +15,9 @@ struct BspLevel {
 
 
 byond_fn!(fn bsp_generate(width, height, hash, map_subsection_min_size, map_subsection_min_room_width, map_subsection_min_room_height) {
-    match bsp_gen(width, height, hash, map_subsection_min_size, map_subsection_min_room_width, map_subsection_min_room_height) {
-        Ok(s) => Some(s),
-        Err(e) => Some(format!("{e}"))
-    }
+    bsp_gen(width, height, hash, map_subsection_min_size, map_subsection_min_room_width, map_subsection_min_room_height).ok()
 });
+
 fn bsp_gen(width_as_str: &str,
     height_as_str: &str,
     hash_as_str: &str,
@@ -34,6 +31,7 @@ fn bsp_gen(width_as_str: &str,
     let mut map_subsection_min_size = map_subsection_min_size_as_str.parse::<i32>()?;
     let map_subsection_min_room_width = map_subsection_min_room_width_as_str.parse::<i32>()?;
     let map_subsection_min_room_height = map_subsection_min_room_height_as_str.parse::<i32>()?;
+
     if map_subsection_min_size < map_subsection_min_room_width || map_subsection_min_size < map_subsection_min_room_height{
         map_subsection_min_size = cmp::max(map_subsection_min_room_width, map_subsection_min_room_height) + 1
     }
@@ -44,14 +42,7 @@ fn bsp_gen(width_as_str: &str,
 
     let level = BspLevel::new(width, height, &mut rng, map_subsection_min_size, map_subsection_min_room_width, map_subsection_min_room_height);
 
-    let mut string = String::new();
-    for room in &level.all_rooms {
-        let serialized = serde_json::to_string(&room).unwrap();
-        let _ = write!(string, "{}", serialized);
-        //println!("serialized = {}", serialized);
-    }
-
-    Ok(format!("{}",serde_json::to_string(&level.all_rooms)?))
+    Ok(serde_json::to_string(&level.all_rooms)?)
 }
 
 impl BspLevel {

src/random_room_placement.rs

@@ -1,5 +1,4 @@
 use std::fmt;
-use std::fmt::Write;
 use rand::distributions::WeightedIndex;
 use rand::prelude::*;
 use rand::rngs::StdRng;
@@ -12,11 +11,9 @@ struct RandomRoomLevel {
 }
 
 byond_fn!(fn random_room_generate(width, height, desired_room_count, hash) {
-    match random_room_gen(width, height, desired_room_count, hash) {
-        Ok(s) => Some(s),
-        Err(e) => Some(format!("{e}"))
-    }
+    random_room_gen(width, height, desired_room_count, hash).ok()
 });
+
 fn random_room_gen(width_as_str: &str,
     height_as_str: &str,
     desired_room_count_as_str: &str,
@@ -35,14 +32,7 @@ fn random_room_gen(width_as_str: &str,
 
     let level = RandomRoomLevel::new(width, height, desired_room_count, &mut rng);
 
-
-    let mut string = String::new();
-    for room in &level.all_rooms {
-        let serialized = serde_json::to_string(&room).unwrap();
-        let _ = write!(string, "{}", serialized);
-    }
-
-    Ok(format!("{}",serde_json::to_string(&level.all_rooms)?))
+    Ok(serde_json::to_string(&level.all_rooms)?)
 }
 
 impl RandomRoomLevel {