Skip to content

Commit 8f48db9

Browse files
yokenzancursoragent
andcommitted
fix(test): avoid version constant collision in loader spec
Replace local Version constant usage with a version test double so the suite can run in aggregate without clashing with Master::Version constants defined by other specs. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 69194d2 commit 8f48db9

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

spec/lib/receiptisan/model/receipt_computer/master/loader_spec.rb

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@
88
require 'logger'
99

1010
RSpec.describe Receiptisan::Model::ReceiptComputer::Master::Loader do
11-
Version = Struct.new(:year)
12-
1311
let(:logger) { Logger.new(nil) }
12+
let(:version) { instance_double(Receiptisan::Model::ReceiptComputer::Master::Version, year: 2024) }
1413

1514
describe '#load' do
1615
it 'キャッシュがなければマスターをロードしてキャッシュを作成する' do
@@ -36,7 +35,7 @@
3635
loader = described_class.new(resolver, logger)
3736
allow(loader).to receive(:load_from_version_and_csv).and_return({ loaded: :master })
3837

39-
result = loader.load(Version.new(2024))
38+
result = loader.load(version)
4039

4140
expect(result).to eq({ loaded: :master })
4241
expect(cache_path).to exist
@@ -68,7 +67,7 @@
6867
loader = described_class.new(resolver, logger)
6968
allow(loader).to receive(:load_from_version_and_csv)
7069

71-
result = loader.load(Version.new(2024))
70+
result = loader.load(version)
7271

7372
expect(result).to eq({ cached: true })
7473
expect(loader).not_to have_received(:load_from_version_and_csv)
@@ -102,7 +101,7 @@
102101
loader = described_class.new(resolver, logger)
103102
allow(loader).to receive(:load_from_version_and_csv).and_return({ reloaded: true })
104103

105-
result = loader.load(Version.new(2024))
104+
result = loader.load(version)
106105

107106
expect(result).to eq({ reloaded: true })
108107
expect(loader).to have_received(:load_from_version_and_csv)
@@ -136,7 +135,7 @@
136135
loader = described_class.new(resolver, logger)
137136
allow(loader).to receive(:load_type_from_csv_paths)
138137

139-
result = loader.load_type(Version.new(2024), :iyakuhin)
138+
result = loader.load_type(version, :iyakuhin)
140139

141140
expect(result).to eq({ cached: :iyakuhin })
142141
expect(loader).not_to have_received(:load_type_from_csv_paths)
@@ -166,7 +165,7 @@
166165
loader = described_class.new(resolver, logger)
167166
allow(loader).to receive(:load_type_from_csv_paths).and_return({ loaded: :iyakuhin })
168167

169-
result = loader.load_type(Version.new(2024), :iyakuhin)
168+
result = loader.load_type(version, :iyakuhin)
170169

171170
expect(result).to eq({ loaded: :iyakuhin })
172171
expect(cache_path).to exist

0 commit comments

Comments
 (0)