install.py feedback

[yokoffing]

Check out install.py created by @Denperidge! The details are here.

Please leave any feedback or questions below.

---

This discussion was created from the release 131.0.

[Lastnight-777]

I was not getting the default profile path so I fixed the parser.
Now it works as expected.

def _get_default_profile_folder():
    config_path = FIREFOX_ROOT.joinpath("profiles.ini")
    
    print(f"Reading {config_path}...")

    config_parser = ConfigParser(strict=False)
    config_parser.read(config_path)

    for section in config_parser.sections():
        if 'Default' in config_parser[section]:
            if config_parser[section]['Default']:
                print("Default detected: " + section)
                return FIREFOX_ROOT.joinpath(config_parser[section]['Default'])

[Denperidge]

Ohh, fascinating! @Lastnight-777 would you be okay with sharing the contents of your profiles.ini file, as well as what Firefox version you're using (and on which OS)?

Indeed, when making a new profile, there is no mention of a Default=0, but I don't know if it's impossible for that to be the case (because as such your code would grab the non-default profile).

Either way, thank you for reporting! At the very least, I'll see to add some kind of fallback to have your case work by default sooner than later. But I do wanna make sure I don't accidentally bug the installer 😌

[Lastnight-777]

I'm currently on Firefox 133.0 on Windows 11.

This is my profiles.ini

[Install308046B0AF4A39CB]
Default=Profiles/dr8lsx29.New Privacy
Locked=1

[Profile0]
Name=privacy
IsRelative=1
Path=Profiles/dr8lsx29.New Privacy

[General]
StartWithLastProfile=1
Version=2

[BackgroundTasksProfiles]
MozillaBackgroundTask-308046B0AF4A39CB-backgroundupdate=o86an3tn.MozillaBackgroundTask-308046B0AF4A39CB-backgroundupdate
MozillaBackgroundTask-308046B0AF4A39CB-defaultagent=o1ykat9j.MozillaBackgroundTask-308046B0AF4A39CB-defaultagent

[Denperidge]

Thank you so much! If I may bother you for one more thing; can you test out if this edited version works? I added some code that should work for your setup!

[Lastnight-777]

The new version works as expected, thank you!

[Denperidge]

Love to hear it! Will PR the change upstream 😌

[Adhjie]

@Denperidge I could do the vanilla script but cant do --help. how to do --help in this script? sorry for the noob question, maybe a docs on this?

[Denperidge]

I should catch the error better though. It is rather non-descript right now

[Adhjie]

@Denperidge
Sorry for the very late reply, but I think downloading user.js file to a folder of choice should be an option besides instal.py option. I only ever use betterfox option if I had researched the params first before using it. since this is sadly irreversible in firefox case. there's also no reset to default option for about:configs options.

I would suggest a docs link for every options inside betterfox's user.js file itself but that's another issue about documentation of each options inside user.js file of betterfox.

[Denperidge]

Yeah, firefox options documentation is definitely out of scope for the installer itself 😅

Am I interpreting correctly you'd like a --directory DIR option?

[Adhjie]

Yeah, firefox options documentation is definitely out of scope for the installer itself 😅

Am I interpreting correctly you'd like a --directory DIR option?

Yeah, basically just downloading the user.js file for inspection later. It's kind of, if using analogy, how Obtainium has an option to just download the apps' .apk files and install it with other apps eg AppManager by MuntashirAkon instead of installing it using Obtainium itself.

[Denperidge]

@Adhjie Is the --profile-dir/-pd arg enough to fulfill this?