Skip to content

Commit 01b2e12

Browse files
authored
Merge pull request kubernetes#124423 from danwinship/network-e2e-features
document (and fixup) sig-network e2e features
2 parents 37ca037 + 52e8815 commit 01b2e12

File tree

2 files changed

+28
-15
lines changed

2 files changed

+28
-15
lines changed

test/e2e/feature/feature.go

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,9 @@ var (
142142
// TODO: document the feature (owning SIG, when to use this feature for a test)
143143
HugePages = framework.WithFeature(framework.ValidFeatures.Add("HugePages"))
144144

145-
// TODO: document the feature (owning SIG, when to use this feature for a test)
145+
// Owner: sig-network
146+
// Marks tests that require a conforming implementation of
147+
// Ingress.networking.k8s.io to be present.
146148
Ingress = framework.WithFeature(framework.ValidFeatures.Add("Ingress"))
147149

148150
// TODO: document the feature (owning SIG, when to use this feature for a test)
@@ -151,7 +153,8 @@ var (
151153
// TODO: document the feature (owning SIG, when to use this feature for a test)
152154
InPlacePodVerticalScaling = framework.WithFeature(framework.ValidFeatures.Add("InPlacePodVerticalScaling"))
153155

154-
// TODO: document the feature (owning SIG, when to use this feature for a test)
156+
// Owner: sig-network
157+
// Marks tests that require a cluster with dual-stack pod and service networks.
155158
IPv6DualStack = framework.WithFeature(framework.ValidFeatures.Add("IPv6DualStack"))
156159

157160
// TODO: document the feature (owning SIG, when to use this feature for a test)
@@ -190,19 +193,26 @@ var (
190193
// TODO: document the feature (owning SIG, when to use this feature for a test)
191194
NEG = framework.WithFeature(framework.ValidFeatures.Add("NEG"))
192195

193-
// TODO: document the feature (owning SIG, when to use this feature for a test)
196+
// Owner: sig-network
197+
// Marks tests that require working external DNS.
194198
NetworkingDNS = framework.WithFeature(framework.ValidFeatures.Add("Networking-DNS"))
195199

196-
// TODO: document the feature (owning SIG, when to use this feature for a test)
200+
// Owner: sig-network
201+
// Marks tests that require connectivity to the Internet via IPv4
197202
NetworkingIPv4 = framework.WithFeature(framework.ValidFeatures.Add("Networking-IPv4"))
198203

199-
// TODO: document the feature (owning SIG, when to use this feature for a test)
204+
// Owner: sig-network
205+
// Marks tests that require connectivity to the Internet via IPv6
200206
NetworkingIPv6 = framework.WithFeature(framework.ValidFeatures.Add("Networking-IPv6"))
201207

202-
// TODO: document the feature (owning SIG, when to use this feature for a test)
208+
// Owner: sig-network
209+
// Marks a single test that creates potentially-disruptive amounts of network
210+
// traffic between nodes.
203211
NetworkingPerformance = framework.WithFeature(framework.ValidFeatures.Add("Networking-Performance"))
204212

205-
// TODO: document the feature (owning SIG, when to use this feature for a test)
213+
// Owner: sig-network
214+
// Marks tests that require a conforming implementation of
215+
// NetworkPolicy.networking.k8s.io to be present.
206216
NetworkPolicy = framework.WithFeature(framework.ValidFeatures.Add("NetworkPolicy"))
207217

208218
// TODO: document the feature (owning SIG, when to use this feature for a test)
@@ -217,13 +227,15 @@ var (
217227
// TODO: document the feature (owning SIG, when to use this feature for a test)
218228
NodeOutOfServiceVolumeDetach = framework.WithFeature(framework.ValidFeatures.Add("NodeOutOfServiceVolumeDetach"))
219229

220-
// TODO: document the feature (owning SIG, when to use this feature for a test)
230+
// Owner: sig-network
231+
// Marks a single test that tests pod-to-pod connectivity between every pair of nodes.
221232
NoSNAT = framework.WithFeature(framework.ValidFeatures.Add("NoSNAT"))
222233

223234
// TODO: document the feature (owning SIG, when to use this feature for a test)
224235
PersistentVolumeLastPhaseTransitionTime = framework.WithFeature(framework.ValidFeatures.Add("PersistentVolumeLastPhaseTransitionTime"))
225236

226-
// TODO: document the feature (owning SIG, when to use this feature for a test)
237+
// Owner: sig-network
238+
// Marks a single test that tests cluster DNS performance with many services.
227239
PerformanceDNS = framework.WithFeature(framework.ValidFeatures.Add("PerformanceDNS"))
228240

229241
// TODO: document the feature (owning SIG, when to use this feature for a test)
@@ -266,7 +278,9 @@ var (
266278
// TODO: document the feature (owning SIG, when to use this feature for a test)
267279
ScopeSelectors = framework.WithFeature(framework.ValidFeatures.Add("ScopeSelectors"))
268280

269-
// TODO: document the feature (owning SIG, when to use this feature for a test)
281+
// Owner: sig-network
282+
// Marks tests that require a pod networking implementation that supports SCTP
283+
// traffic between pods.
270284
SCTPConnectivity = framework.WithFeature(framework.ValidFeatures.Add("SCTPConnectivity"))
271285

272286
// TODO: document the feature (owning SIG, when to use this feature for a test)
@@ -282,7 +296,9 @@ var (
282296
// TODO: remove when SELinuxMount feature gate is enabled by default.
283297
SELinuxMountReadWriteOncePodOnly = framework.WithFeature(framework.ValidFeatures.Add("SELinuxMountReadWriteOncePodOnly"))
284298

285-
// TODO: document the feature (owning SIG, when to use this feature for a test)
299+
// Owner: sig-network
300+
// Marks tests of KEP-1880 that require the `MultiCIDRServiceAllocator` feature gate
301+
// and the networking.k8s.io/v1alpha1 API.
286302
ServiceCIDRs = framework.WithFeature(framework.ValidFeatures.Add("ServiceCIDRs"))
287303

288304
// TODO: document the feature (owning SIG, when to use this feature for a test)
@@ -327,9 +343,6 @@ var (
327343
// TODO: document the feature (owning SIG, when to use this feature for a test)
328344
TopologyManager = framework.WithFeature(framework.ValidFeatures.Add("TopologyManager"))
329345

330-
// TODO: document the feature (owning SIG, when to use this feature for a test)
331-
UDP = framework.WithFeature(framework.ValidFeatures.Add("UDP"))
332-
333346
// TODO: document the feature (owning SIG, when to use this feature for a test)
334347
Upgrade = framework.WithFeature(framework.ValidFeatures.Add("Upgrade"))
335348

test/e2e/network/netpol/network_policy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,7 @@ var _ = common.SIGDescribe("Netpol", func() {
893893
ValidateOrFail(k8s, &TestCase{ToPort: 80, Protocol: v1.ProtocolTCP, Reachability: reachability})
894894
})
895895

896-
f.It("should enforce ingress policy allowing any port traffic to a server on a specific protocol", feature.NetworkPolicy, feature.UDP, func(ctx context.Context) {
896+
f.It("should enforce ingress policy allowing any port traffic to a server on a specific protocol", feature.NetworkPolicy, func(ctx context.Context) {
897897
protocols := []v1.Protocol{protocolTCP, protocolUDP}
898898
ports := []int32{80}
899899
k8s = initializeResources(ctx, f, protocols, ports)

0 commit comments

Comments
 (0)