Skip to content

Commit 04f7a86

Browse files
committed
density test: adjust CPU and memory limits
Adjusted limits based on recent job log: I1028 20:05:42.079182 1002 resource_usage_test.go:199] Resource usage: container cpu(cores) memory_working_set(MB) memory_rss(MB) "kubelet" 0.024 22.17 14.20 "runtime" 0.041 409.70 84.21 I1028 20:05:42.079274 1002 resource_usage_test.go:206] CPU usage of containers: container 50th% 90th% 95th% 99th% 100th% "/" N/A N/A N/A N/A N/A "runtime" 0.014 0.834 0.834 0.834 1.083 "kubelet" 0.023 0.093 0.093 0.093 0.164 Increasing 95th percentile for runtime CPU usage should also make pull-kubernetes-node-kubelet-containerd-flaky less flaky.
1 parent 5f594f4 commit 04f7a86

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

test/e2e_node/density_test.go

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,18 +77,24 @@ var _ = SIGDescribe("Density", framework.WithSerial(), framework.WithSlow(), fun
7777
})
7878

7979
f.Context("create a batch of pods", framework.WithFlaky(), func() {
80-
// TODO(coufon): the values are generous, set more precise limits with benchmark data
81-
// and add more tests
80+
// If this test case fails with am error similar to
81+
// "container "runtime": expected 95th% usage < 0.900; got 0.941",
82+
// it is likely that cpuLimits or memLimits need to be increased.
83+
// Actual resource usage values can be found in the test output, e.g.:
84+
// I1029 11:28:15.671913 1005 resource_usage_test.go:206] CPU usage of containers:
85+
// container 50th% 90th% 95th% 99th% 100th%
86+
// "runtime" 0.004 0.941 0.941 0.941 0.976
87+
// "kubelet" 0.009 0.082 0.082 0.082 0.101
8288
dTests := []densityTest{
8389
{
8490
podsNr: 10,
8591
interval: 0 * time.Millisecond,
8692
cpuLimits: e2ekubelet.ContainersCPUSummary{
87-
kubeletstatsv1alpha1.SystemContainerKubelet: {0.50: 0.30, 0.95: 0.50},
88-
kubeletstatsv1alpha1.SystemContainerRuntime: {0.50: 0.40, 0.95: 0.60},
93+
kubeletstatsv1alpha1.SystemContainerKubelet: {0.50: 0.1, 0.95: 0.20},
94+
kubeletstatsv1alpha1.SystemContainerRuntime: {0.50: 0.1, 0.95: 1.5},
8995
},
9096
memLimits: e2ekubelet.ResourceUsagePerContainer{
91-
kubeletstatsv1alpha1.SystemContainerKubelet: &e2ekubelet.ContainerResourceUsage{MemoryRSSInBytes: 100 * 1024 * 1024},
97+
kubeletstatsv1alpha1.SystemContainerKubelet: &e2ekubelet.ContainerResourceUsage{MemoryRSSInBytes: 50 * 1024 * 1024},
9298
kubeletstatsv1alpha1.SystemContainerRuntime: &e2ekubelet.ContainerResourceUsage{MemoryRSSInBytes: 500 * 1024 * 1024},
9399
},
94100
// percentile limit of single pod startup latency

0 commit comments

Comments
 (0)