node: cpumgr: log: make errors louder

ffromani · ffromani · commit 0a9b17771da7 · 2024-07-22T14:04:05.000+02:00
We have a special case which is not supposed to happen.
Make it louder with default log settings to make sure this is visible.

Signed-off-by: Francesco Romani &lt;fromani@redhat.com&gt;
diff --git a/pkg/kubelet/cm/cpumanager/cpu_manager.go b/pkg/kubelet/cm/cpumanager/cpu_manager.go
@@ -467,7 +467,7 @@ func (m *manager) reconcileState() (success []reconciledContainer, failure []rec
 			cset := m.state.GetCPUSetOrDefault(string(pod.UID), container.Name)
 			if cset.IsEmpty() {
 				// NOTE: This should not happen outside of tests.
-				klog.V(4).InfoS("ReconcileState: skipping container; assigned cpuset is empty", "pod", klog.KObj(pod), "containerName", container.Name)
+				klog.V(2).InfoS("ReconcileState: skipping container; assigned cpuset is empty", "pod", klog.KObj(pod), "containerName", container.Name)
 				failure = append(failure, reconciledContainer{pod.Name, container.Name, containerID})
 				continue
 			}

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,7 @@ func (m *manager) reconcileState() (success []reconciledContainer, failure []rec`
`467`	`467`	`cset := m.state.GetCPUSetOrDefault(string(pod.UID), container.Name)`
`468`	`468`	`if cset.IsEmpty() {`
`469`	`469`	`// NOTE: This should not happen outside of tests.`
`470`		`- klog.V(4).InfoS("ReconcileState: skipping container; assigned cpuset is empty", "pod", klog.KObj(pod), "containerName", container.Name)`
	`470`	`+ klog.V(2).InfoS("ReconcileState: skipping container; assigned cpuset is empty", "pod", klog.KObj(pod), "containerName", container.Name)`
`471`	`471`	`failure = append(failure, reconciledContainer{pod.Name, container.Name, containerID})`
`472`	`472`	`continue`
`473`	`473`	`}`