Skip to content

Commit 0d14bac

Browse files
committed
Preserve testing of RetryGenerateName feature disablement
1 parent e3cae09 commit 0d14bac

File tree

1 file changed

+5
-0
lines changed
  • staging/src/k8s.io/apiserver/pkg/registry/generic/registry

1 file changed

+5
-0
lines changed

staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ import (
4545
"k8s.io/apimachinery/pkg/selection"
4646
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
4747
"k8s.io/apimachinery/pkg/util/validation/field"
48+
"k8s.io/apimachinery/pkg/util/version"
4849
"k8s.io/apimachinery/pkg/util/wait"
4950
"k8s.io/apiserver/pkg/apis/example"
5051
examplev1 "k8s.io/apiserver/pkg/apis/example/v1"
@@ -447,6 +448,8 @@ func TestStoreCreateWithRetryNameGenerate(t *testing.T) {
447448
}
448449

449450
func TestStoreCreateWithRetryNameGenerateFeatureDisabled(t *testing.T) {
451+
// Preserve testing of disabled RetryGenerateName feature gate since it can still be disabled when emulation version is set.
452+
featuregatetesting.SetFeatureGateEmulationVersionDuringTest(t, utilfeature.DefaultFeatureGate, version.MustParse("1.31"))
450453
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.RetryGenerateName, false)
451454
namedObj := func(id int) *example.Pod {
452455
return &example.Pod{
@@ -2981,6 +2984,8 @@ func (p *predictableNameGenerator) GenerateName(base string) string {
29812984
}
29822985

29832986
func TestStoreCreateGenerateNameConflict(t *testing.T) {
2987+
// Preserve testing of disabled RetryGenerateName feature gate since it can still be disabled when emulation version is set.
2988+
featuregatetesting.SetFeatureGateEmulationVersionDuringTest(t, utilfeature.DefaultFeatureGate, version.MustParse("1.31"))
29842989
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.RetryGenerateName, false)
29852990

29862991
// podA will be stored with name foo12345

0 commit comments

Comments
 (0)