Skip to content

Commit 0d2ad0e

Browse files
committed
fix: clean up testifylint configuration in golangci-lint
Signed-off-by: Matthieu MOREL <[email protected]>
1 parent 93f82d2 commit 0d2ad0e

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

hack/golangci-hints.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,5 +185,3 @@ linters-settings: # please keep this alphabetized
185185
- "all"
186186
testifylint:
187187
enable-all: true
188-
disable: # TODO: remove each disabled rule and fix it
189-
- require-error

hack/golangci.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -239,11 +239,6 @@ linters-settings: # please keep this alphabetized
239239
testifylint:
240240
enable-all: true
241241
disable: # TODO: remove each disabled rule and fix it
242-
- compares
243-
- error-is-as
244-
- error-nil
245-
- expected-actual
246242
- float-compare
247243
- go-require
248-
- nil-compare
249244
- require-error

hack/golangci.yaml.in

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -210,14 +210,11 @@ linters-settings: # please keep this alphabetized
210210
{{- end}}
211211
testifylint:
212212
enable-all: true
213+
{{- if not .Hints }}
213214
disable: # TODO: remove each disabled rule and fix it
214-
{{- if .Base}}
215-
- compares
216-
- error-is-as
217-
- error-nil
218-
- expected-actual
215+
{{- if .Base }}
219216
- float-compare
220217
- go-require
221-
- nil-compare
222-
{{- end}}
218+
{{- end}}
223219
- require-error
220+
{{- end}}

0 commit comments

Comments
 (0)