Skip to content

Commit 104b5a0

Browse files
committed
Fix assertion for host network hostname e2e test
The original assumption is wrong, as the node name may not match the hostname of the host in some circumstances. Signed-off-by: Sascha Grunert <[email protected]>
1 parent a07d3c4 commit 104b5a0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/e2e/network/dns.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -686,8 +686,8 @@ var _ = common.SIGDescribe("DNS HostNetwork", func() {
686686
stdout, err := e2eoutput.RunHostCmd(testAgnhostPod.Namespace, testAgnhostPod.Name, "hostname")
687687
framework.ExpectNoError(err, "failed to run command hostname: %s", stdout)
688688
hostname := strings.TrimSpace(stdout)
689-
if node.Name != hostname {
690-
framework.Failf("expected hostname: %s, got: %s", node.Name, hostname)
689+
if dnsTestPodHostName == hostname {
690+
framework.Failf("https://issues.k8s.io/67019 expected spec.Hostname %s to be ignored", hostname)
691691
}
692692
})
693693

0 commit comments

Comments
 (0)