Skip to content

Commit 14dafc3

Browse files
authored
Merge pull request kubernetes#129434 from xigang/crd_handler
refactor: simplify boolean expressions in CRD handler
2 parents 0e78cf1 + deb234c commit 14dafc3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,13 +660,13 @@ func (r *crdHandler) getOrCreateServingInfoFor(uid types.UID, name string) (*crd
660660
return nil, fmt.Errorf("failed converting CRD validation to internal version: %v", err)
661661
}
662662
s, err := structuralschema.NewStructural(internalValidation.OpenAPIV3Schema)
663-
if crd.Spec.PreserveUnknownFields == false && err != nil {
663+
if !crd.Spec.PreserveUnknownFields && err != nil {
664664
// This should never happen. If it does, it is a programming error.
665665
utilruntime.HandleError(fmt.Errorf("failed to convert schema to structural: %v", err))
666666
return nil, fmt.Errorf("the server could not properly serve the CR schema") // validation should avoid this
667667
}
668668

669-
if crd.Spec.PreserveUnknownFields == false {
669+
if !crd.Spec.PreserveUnknownFields {
670670
// we don't own s completely, e.g. defaults are not deep-copied. So better make a copy here.
671671
s = s.DeepCopy()
672672

0 commit comments

Comments
 (0)