Skip to content

Commit 187b43d

Browse files
committed
enable dep-approvers for staging go.mod/go.sum
NOTE: to use filters, _all_ entries must be under filters https://go.k8s.io/owners/#filters
1 parent 0a60b10 commit 187b43d

File tree

4 files changed

+85
-43
lines changed

4 files changed

+85
-43
lines changed

staging/OWNERS

Lines changed: 31 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,34 @@
33
options:
44
# make root approval non-recursive
55
no_parent_owners: true
6-
approvers:
7-
- dchen1107
8-
- dims
9-
- liggitt
10-
- smarterclayton
11-
- thockin
12-
- wojtek-t
13-
reviewers:
14-
- caesarxuchao
15-
- dchen1107
16-
- deads2k
17-
- dims
18-
- liggitt
19-
- mikedanese
20-
- smarterclayton
21-
- sttts
22-
- thockin
23-
- wojtek-t
24-
emeritus_approvers:
25-
- lavalamp
6+
filters:
7+
# to use filters all entries must be under filters https://go.k8s.io/owners/#filters
8+
# use .* for approvers that should have all files
9+
".*":
10+
approvers:
11+
- dchen1107
12+
- dims
13+
- liggitt
14+
- smarterclayton
15+
- thockin
16+
- wojtek-t
17+
reviewers:
18+
- caesarxuchao
19+
- dchen1107
20+
- deads2k
21+
- dims
22+
- liggitt
23+
- mikedanese
24+
- smarterclayton
25+
- sttts
26+
- thockin
27+
- wojtek-t
28+
emeritus_approvers:
29+
- lavalamp
30+
# go.{mod,sum} files relate to go dependencies, and should be reviewed by the
31+
# dep-approvers
32+
"go\\.(mod|sum)$":
33+
approvers:
34+
- dep-approvers
35+
reviewers:
36+
- dep-reviewers

staging/src/k8s.io/api/OWNERS

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,20 @@
44
options:
55
no_parent_owners: true
66
filters:
7+
# to use filters all entries must be under filters https://go.k8s.io/owners/#filters
8+
# use .* for approvers that should have all files
79
".*":
810
approvers:
911
- api-approvers
1012
reviewers:
1113
- api-reviewers
14+
# go.{mod,sum} files relate to go dependencies, and should be reviewed by the
15+
# dep-approvers
16+
"go\\.(mod|sum)$":
17+
approvers:
18+
- dep-approvers
19+
reviewers:
20+
- dep-reviewers
1221
# only auto-label go file changes as kind/api-change
1322
"\\.go$":
1423
labels:

staging/src/k8s.io/cri-api/OWNERS

Lines changed: 25 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,28 @@
33
# Disable inheritance as this is owned by sig-node (should mirror same contents as pkg/kubelet/OWNERS)
44
options:
55
no_parent_owners: true
6-
approvers:
7-
- dims
8-
- feiskyer
9-
- sig-node-approvers
10-
- api-approvers
11-
- sig-node-cri-approvers
12-
reviewers:
13-
- sig-node-reviewers
14-
- dims
15-
labels:
16-
- sig/node
17-
- area/kubelet
18-
emeritus_approvers:
19-
- resouer
6+
filters:
7+
# to use filters all entries must be under filters https://go.k8s.io/owners/#filters
8+
# use .* for approvers that should have all files
9+
".*":
10+
approvers:
11+
- dims
12+
- feiskyer
13+
- sig-node-approvers
14+
- api-approvers
15+
- sig-node-cri-approvers
16+
reviewers:
17+
- sig-node-reviewers
18+
- dims
19+
labels:
20+
- sig/node
21+
- area/kubelet
22+
emeritus_approvers:
23+
- resouer
24+
# go.{mod,sum} files relate to go dependencies, and should be reviewed by the
25+
# dep-approvers
26+
"go\\.(mod|sum)$":
27+
approvers:
28+
- dep-approvers
29+
reviewers:
30+
- dep-reviewers

staging/src/k8s.io/cri-client/OWNERS

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,23 @@
33
# Disable inheritance as this is owned by sig-node
44
options:
55
no_parent_owners: true
6-
approvers:
7-
- sig-node-approvers
8-
- api-approvers
9-
- sig-node-cri-approvers
10-
reviewers:
11-
- sig-node-reviewers
12-
labels:
13-
- sig/node
14-
- area/kubelet
6+
filters:
7+
# to use filters all entries must be under filters https://go.k8s.io/owners/#filters
8+
# use .* for approvers that should have all files
9+
".*":
10+
approvers:
11+
- sig-node-approvers
12+
- api-approvers
13+
- sig-node-cri-approvers
14+
reviewers:
15+
- sig-node-reviewers
16+
labels:
17+
- sig/node
18+
- area/kubelet
19+
# go.{mod,sum} files relate to go dependencies, and should be reviewed by the
20+
# dep-approvers
21+
"go\\.(mod|sum)$":
22+
approvers:
23+
- dep-approvers
24+
reviewers:
25+
- dep-reviewers

0 commit comments

Comments
 (0)