chore(validatingadmissionpolicystatus): use WaitForCacheSync after sharedInformerFactory Start in unit test

omerap12 · omerap12 · commit 18c0d6a79e5c · 2024-08-08T14:45:26.000+03:00
Signed-off-by: Omer Aplatony &lt;omerap12@gmail.com&gt;
diff --git a/pkg/controller/validatingadmissionpolicystatus/controller_test.go b/pkg/controller/validatingadmissionpolicystatus/controller_test.go
@@ -114,6 +114,7 @@ func TestTypeChecking(t *testing.T) {
 				t.Fatalf("cannot create controller: %v", err)
 			}
 			informerFactory.Start(ctx.Done())
+			informerFactory.WaitForCacheSync(ctx.Done())
 			go controller.Run(ctx, 1)
 			err = wait.PollUntilContextCancel(ctx, time.Second, false, func(ctx context.Context) (done bool, err error) {
 				name := policy.Name

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,7 @@ func TestTypeChecking(t *testing.T) {`
`114`	`114`	`t.Fatalf("cannot create controller: %v", err)`
`115`	`115`	`}`
`116`	`116`	`informerFactory.Start(ctx.Done())`
	`117`	`+ informerFactory.WaitForCacheSync(ctx.Done())`
`117`	`118`	`go controller.Run(ctx, 1)`
`118`	`119`	`err = wait.PollUntilContextCancel(ctx, time.Second, false, func(ctx context.Context) (done bool, err error) {`
`119`	`120`	`name := policy.Name`