Merge pull request kubernetes#128722 from dims/possible-fix-for-alpha-feature-breaking-tests

k8s-ci-robot · web-flow · commit 1b08de5f7f96 · 2024-11-09T16:28:43.000Z
Fix for alpha CI jobs failing with AllowUnsafeMalformedObjectDeletion switched on
diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/delete.go b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/delete.go
@@ -306,7 +306,7 @@ func DeleteCollection(r rest.CollectionDeleter, checkBody bool, scope *RequestSc
 		}
 
 		if utilfeature.DefaultFeatureGate.Enabled(features.AllowUnsafeMalformedObjectDeletion) {
-			if options != nil && ptr.Deref(options.IgnoreStoreReadErrorWithClusterBreakingPotential, true) {
+			if options != nil && ptr.Deref(options.IgnoreStoreReadErrorWithClusterBreakingPotential, false) {
 				fieldErrList := field.ErrorList{
 					field.Invalid(field.NewPath("ignoreStoreReadErrorWithClusterBreakingPotential"), true, "is not allowed with DELETECOLLECTION, try again after removing the option"),
 				}

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,7 @@ func DeleteCollection(r rest.CollectionDeleter, checkBody bool, scope *RequestSc`
`306`	`306`	`}`
`307`	`307`
`308`	`308`	`if utilfeature.DefaultFeatureGate.Enabled(features.AllowUnsafeMalformedObjectDeletion) {`
`309`		`- if options != nil && ptr.Deref(options.IgnoreStoreReadErrorWithClusterBreakingPotential, true) {`
	`309`	`+ if options != nil && ptr.Deref(options.IgnoreStoreReadErrorWithClusterBreakingPotential, false) {`
`310`	`310`	`fieldErrList := field.ErrorList{`
`311`	`311`	`field.Invalid(field.NewPath("ignoreStoreReadErrorWithClusterBreakingPotential"), true, "is not allowed with DELETECOLLECTION, try again after removing the option"),`
`312`	`312`	`}`