Skip to content

Commit 1c2b002

Browse files
authored
Merge pull request kubernetes#120994 from thockin/kube_codegen_extra_peer_dirs
Add --extra-peer in conversion in kube_codegen
2 parents 39697a9 + 69a3e3d commit 1c2b002

File tree

1 file changed

+23
-9
lines changed

1 file changed

+23
-9
lines changed

staging/src/k8s.io/code-generator/kube_codegen.sh

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,16 @@ function kube::codegen::internal::git_grep() {
5050
# --boilerplate <string = path_to_kube_codegen_boilerplate>
5151
# An optional override for the header file to insert into generated files.
5252
#
53+
# --extra-peer-dir <string>
54+
# An optional list (this flag may be specified multiple times) of "extra"
55+
# directories to consider during conversion generation.
56+
#
5357
function kube::codegen::gen_helpers() {
5458
local in_pkg_root=""
5559
local out_base="" # gengo needs the output dir must be $out_base/$out_pkg_root
5660
local boilerplate="${KUBE_CODEGEN_ROOT}/hack/boilerplate.go.txt"
5761
local v="${KUBE_VERBOSE:-0}"
62+
local extra_peers=()
5863

5964
while [ "$#" -gt 0 ]; do
6065
case "$1" in
@@ -70,6 +75,10 @@ function kube::codegen::gen_helpers() {
7075
boilerplate="$2"
7176
shift 2
7277
;;
78+
"--extra-peer-dir")
79+
extra_peers+=("$2")
80+
shift 2
81+
;;
7382
*)
7483
echo "unknown argument: $1" >&2
7584
return 1
@@ -128,16 +137,16 @@ function kube::codegen::gen_helpers() {
128137
":(glob)${root}"/'**/zz_generated.deepcopy.go' \
129138
| xargs -0 rm -f
130139

131-
local inputs=()
140+
local input_args=()
132141
for arg in "${input_pkgs[@]}"; do
133-
inputs+=("--input-dirs" "$arg")
142+
input_args+=("--input-dirs" "$arg")
134143
done
135144
"${gobin}/deepcopy-gen" \
136145
-v "${v}" \
137146
-O zz_generated.deepcopy \
138147
--go-header-file "${boilerplate}" \
139148
--output-base "${out_base}" \
140-
"${inputs[@]}"
149+
"${input_args[@]}"
141150
fi
142151

143152
# Defaults
@@ -162,16 +171,16 @@ function kube::codegen::gen_helpers() {
162171
":(glob)${root}"/'**/zz_generated.defaults.go' \
163172
| xargs -0 rm -f
164173

165-
local inputs=()
174+
local input_args=()
166175
for arg in "${input_pkgs[@]}"; do
167-
inputs+=("--input-dirs" "$arg")
176+
input_args+=("--input-dirs" "$arg")
168177
done
169178
"${gobin}/defaulter-gen" \
170179
-v "${v}" \
171180
-O zz_generated.defaults \
172181
--go-header-file "${boilerplate}" \
173182
--output-base "${out_base}" \
174-
"${inputs[@]}"
183+
"${input_args[@]}"
175184
fi
176185

177186
# Conversions
@@ -196,16 +205,21 @@ function kube::codegen::gen_helpers() {
196205
":(glob)${root}"/'**/zz_generated.conversion.go' \
197206
| xargs -0 rm -f
198207

199-
local inputs=()
208+
local input_args=()
200209
for arg in "${input_pkgs[@]}"; do
201-
inputs+=("--input-dirs" "$arg")
210+
input_args+=("--input-dirs" "$arg")
211+
done
212+
local extra_peer_args=()
213+
for arg in "${extra_peers[@]:+"${extra_peers[@]}"}"; do
214+
extra_peer_args+=("--extra-peer-dirs" "$arg")
202215
done
203216
"${gobin}/conversion-gen" \
204217
-v "${v}" \
205218
-O zz_generated.conversion \
206219
--go-header-file "${boilerplate}" \
207220
--output-base "${out_base}" \
208-
"${inputs[@]}"
221+
"${extra_peer_args[@]:+"${extra_peer_args[@]}"}" \
222+
"${input_args[@]}"
209223
fi
210224
}
211225

0 commit comments

Comments
 (0)