Update scale sub-resource to return the same error everywhere

Signed-off-by: Maciej Szulik <[email protected]>

Author: soltysh

pkg/registry/apps/deployment/storage/storage.go

@@ -306,7 +306,7 @@ func (r *ScaleREST) Destroy() {
 func (r *ScaleREST) Get(ctx context.Context, name string, options *metav1.GetOptions) (runtime.Object, error) {
 	obj, err := r.store.Get(ctx, name, options)
 	if err != nil {
-		return nil, errors.NewNotFound(apps.Resource("deployments/scale"), name)
+		return nil, err
 	}
 	deployment := obj.(*apps.Deployment)
 	scale, err := scaleFromDeployment(deployment)

pkg/registry/apps/replicaset/storage/storage.go

@@ -202,7 +202,7 @@ func (r *ScaleREST) Destroy() {
 func (r *ScaleREST) Get(ctx context.Context, name string, options *metav1.GetOptions) (runtime.Object, error) {
 	obj, err := r.store.Get(ctx, name, options)
 	if err != nil {
-		return nil, errors.NewNotFound(apps.Resource("replicasets/scale"), name)
+		return nil, err
 	}
 	rs := obj.(*apps.ReplicaSet)
 	scale, err := scaleFromReplicaSet(rs)

pkg/registry/core/replicationcontroller/storage/storage.go

@@ -190,7 +190,7 @@ func (r *ScaleREST) Destroy() {
 func (r *ScaleREST) Get(ctx context.Context, name string, options *metav1.GetOptions) (runtime.Object, error) {
 	obj, err := r.store.Get(ctx, name, options)
 	if err != nil {
-		return nil, errors.NewNotFound(autoscaling.Resource("replicationcontrollers/scale"), name)
+		return nil, err
 	}
 	rc := obj.(*api.ReplicationController)
 	return scaleFromRC(rc), nil