Skip to content

Commit 215d0b0

Browse files
lixivardaguclu
lixiv
and
ardaguclu
authored
Add tests for kubectl qos (kubernetes#129388)
* Add tests for kubectl qos * Update staging/src/k8s.io/kubectl/pkg/util/qos/qos_test.go Co-authored-by: Arda Güçlü <[email protected]> --------- Co-authored-by: Arda Güçlü <[email protected]>
1 parent 8f330c6 commit 215d0b0

File tree

1 file changed

+201
-0
lines changed

1 file changed

+201
-0
lines changed

‎staging/src/k8s.io/kubectl/pkg/util/qos/qos_test.go‎

Lines changed: 201 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,201 @@
1+
/*
2+
Copyright 2024 The Kubernetes Authors.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/
16+
17+
package qos
18+
19+
import (
20+
"reflect"
21+
"testing"
22+
23+
corev1 "k8s.io/api/core/v1"
24+
"k8s.io/apimachinery/pkg/api/resource"
25+
)
26+
27+
func TestGetPodQOS(t *testing.T) {
28+
tests := []struct {
29+
name string
30+
pod *corev1.Pod
31+
want corev1.PodQOSClass
32+
}{
33+
{
34+
name: "guaranteed pod with status",
35+
pod: &corev1.Pod{
36+
Status: corev1.PodStatus{
37+
QOSClass: corev1.PodQOSGuaranteed,
38+
},
39+
},
40+
want: corev1.PodQOSGuaranteed,
41+
},
42+
{
43+
name: "burstable pod with status",
44+
pod: &corev1.Pod{
45+
Status: corev1.PodStatus{
46+
QOSClass: corev1.PodQOSBurstable,
47+
},
48+
},
49+
want: corev1.PodQOSBurstable,
50+
},
51+
{
52+
name: "besteffort pod with status",
53+
pod: &corev1.Pod{
54+
Status: corev1.PodStatus{
55+
QOSClass: corev1.PodQOSBestEffort,
56+
},
57+
},
58+
want: corev1.PodQOSBestEffort,
59+
},
60+
{
61+
name: "guaranteed pod without status",
62+
pod: &corev1.Pod{
63+
Spec: corev1.PodSpec{
64+
Containers: []corev1.Container{
65+
{
66+
Name: "container1",
67+
Resources: corev1.ResourceRequirements{
68+
Requests: corev1.ResourceList{
69+
corev1.ResourceCPU: resource.MustParse("1"),
70+
corev1.ResourceMemory: resource.MustParse("1Gi"),
71+
},
72+
Limits: corev1.ResourceList{
73+
corev1.ResourceCPU: resource.MustParse("1"),
74+
corev1.ResourceMemory: resource.MustParse("1Gi"),
75+
},
76+
},
77+
},
78+
},
79+
},
80+
},
81+
want: corev1.PodQOSGuaranteed,
82+
},
83+
{
84+
name: "guaranteed pod with two containers",
85+
pod: &corev1.Pod{
86+
Spec: corev1.PodSpec{
87+
Containers: []corev1.Container{
88+
{
89+
Name: "container1",
90+
Resources: corev1.ResourceRequirements{
91+
Requests: corev1.ResourceList{
92+
corev1.ResourceCPU: resource.MustParse("1"),
93+
corev1.ResourceMemory: resource.MustParse("1Gi"),
94+
},
95+
Limits: corev1.ResourceList{
96+
corev1.ResourceCPU: resource.MustParse("1"),
97+
corev1.ResourceMemory: resource.MustParse("1Gi"),
98+
},
99+
},
100+
},
101+
{
102+
Name: "container2",
103+
Resources: corev1.ResourceRequirements{
104+
Requests: corev1.ResourceList{
105+
corev1.ResourceCPU: resource.MustParse("1"),
106+
corev1.ResourceMemory: resource.MustParse("1Gi"),
107+
},
108+
Limits: corev1.ResourceList{
109+
corev1.ResourceCPU: resource.MustParse("1"),
110+
corev1.ResourceMemory: resource.MustParse("1Gi"),
111+
},
112+
},
113+
},
114+
},
115+
},
116+
},
117+
want: corev1.PodQOSGuaranteed,
118+
},
119+
{
120+
name: "burstable pod without status",
121+
pod: &corev1.Pod{
122+
Spec: corev1.PodSpec{
123+
Containers: []corev1.Container{
124+
{
125+
Name: "container1",
126+
Resources: corev1.ResourceRequirements{
127+
Requests: corev1.ResourceList{
128+
corev1.ResourceCPU: resource.MustParse("100m"),
129+
corev1.ResourceMemory: resource.MustParse("1Gi"),
130+
},
131+
Limits: corev1.ResourceList{
132+
corev1.ResourceCPU: resource.MustParse("1"),
133+
corev1.ResourceMemory: resource.MustParse("1Gi"),
134+
},
135+
},
136+
},
137+
},
138+
},
139+
},
140+
want: corev1.PodQOSBurstable,
141+
},
142+
{
143+
name: "burstable pod with two containers",
144+
pod: &corev1.Pod{
145+
Spec: corev1.PodSpec{
146+
Containers: []corev1.Container{
147+
{
148+
Name: "container1",
149+
Resources: corev1.ResourceRequirements{
150+
Requests: corev1.ResourceList{
151+
corev1.ResourceCPU: resource.MustParse("1"),
152+
corev1.ResourceMemory: resource.MustParse("1Gi"),
153+
},
154+
Limits: corev1.ResourceList{
155+
corev1.ResourceCPU: resource.MustParse("1"),
156+
corev1.ResourceMemory: resource.MustParse("1Gi"),
157+
},
158+
},
159+
},
160+
{
161+
Name: "container2",
162+
Resources: corev1.ResourceRequirements{
163+
Requests: corev1.ResourceList{
164+
corev1.ResourceCPU: resource.MustParse("100m"),
165+
corev1.ResourceMemory: resource.MustParse("1Gi"),
166+
},
167+
Limits: corev1.ResourceList{
168+
corev1.ResourceCPU: resource.MustParse("1"),
169+
corev1.ResourceMemory: resource.MustParse("1Gi"),
170+
},
171+
},
172+
},
173+
},
174+
},
175+
},
176+
want: corev1.PodQOSBurstable,
177+
},
178+
{
179+
name: "besteffort pod without status",
180+
pod: &corev1.Pod{
181+
Spec: corev1.PodSpec{
182+
Containers: []corev1.Container{
183+
{
184+
Name: "container1",
185+
Resources: corev1.ResourceRequirements{},
186+
},
187+
},
188+
},
189+
},
190+
want: corev1.PodQOSBestEffort,
191+
},
192+
}
193+
194+
for _, tt := range tests {
195+
t.Run(tt.name, func(t *testing.T) {
196+
if got := GetPodQOS(tt.pod); !reflect.DeepEqual(got, tt.want) {
197+
t.Errorf("unexpected PodQOSClass actual %s, expected %s", got, tt.want)
198+
}
199+
})
200+
}
201+
}

0 commit comments

Comments
 (0)