Skip to content

Commit 261236b

Browse files
authored
Merge pull request kubernetes#129810 from pohly/dra-test-driver-examples
DRA: fix test-driver examples
2 parents 2973b4b + 013f65b commit 261236b

File tree

8 files changed

+47
-75
lines changed

8 files changed

+47
-75
lines changed

test/e2e/dra/test-driver/README.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,18 +59,14 @@ RUNTIME_CONFIG="resource.k8s.io/v1alpha3" FEATURE_GATES=DynamicResourceAllocatio
5959
```
6060

6161
In another:
62-
```console
63-
go run ./test/e2e/dra/test-driver --feature-gates ContextualLogging=true -v=5 controller
6462
```
65-
66-
In yet another:
67-
```console
6863
sudo mkdir -p /var/run/cdi && sudo chmod a+rwx /var/run/cdi /var/lib/kubelet/plugins_registry
69-
go run ./test/e2e/dra/test-driver --feature-gates ContextualLogging=true -v=5 kubelet-plugin --node-name=127.0.0.1
64+
KUBECONFIG=/var/run/kubernetes/admin.kubeconfig go run ./test/e2e/dra/test-driver -v=5 kubelet-plugin --node-name=127.0.0.1
7065
```
7166

7267
And finally:
7368
```console
69+
$ export KUBECONFIG=/var/run/kubernetes/admin.kubeconfig
7470
$ kubectl create -f test/e2e/dra/test-driver/deploy/example/resourceclass.yaml
7571
resourceclass/example created
7672
$ kubectl create -f test/e2e/dra/test-driver/deploy/example/pod-inline.yaml

test/e2e/dra/test-driver/app/server.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ func NewCommand() *cobra.Command {
184184
fs = kubeletPluginFlagSets.FlagSet("CDI")
185185
cdiDir := fs.String("cdi-dir", "/var/run/cdi", "directory for dynamically created CDI JSON files")
186186
nodeName := fs.String("node-name", "", "name of the node that the kubelet plugin is responsible for")
187+
numDevices := fs.Int("num-devices", 4, "number of devices to simulate per node")
187188
fs = kubeletPlugin.Flags()
188189
for _, f := range kubeletPluginFlagSets.FlagSets {
189190
fs.AddFlagSet(f)
@@ -203,7 +204,7 @@ func NewCommand() *cobra.Command {
203204
return errors.New("--node-name not set")
204205
}
205206

206-
plugin, err := StartPlugin(cmd.Context(), *cdiDir, *driverName, clientset, *nodeName, FileOperations{},
207+
plugin, err := StartPlugin(cmd.Context(), *cdiDir, *driverName, clientset, *nodeName, FileOperations{NumDevices: *numDevices},
207208
kubeletplugin.PluginSocketPath(*endpoint),
208209
kubeletplugin.RegistrarSocketPath(path.Join(*pluginRegistrationPath, *driverName+"-reg.sock")),
209210
kubeletplugin.KubeletPluginSocketPath(*draAddress),

test/e2e/dra/test-driver/deploy/example/broken-resourceclass.yaml

Lines changed: 0 additions & 14 deletions
This file was deleted.

test/e2e/dra/test-driver/deploy/example/deviceclass.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
apiVersion: resource.k8s.io/v1alpha3
2-
kind: ResourceClass
1+
apiVersion: resource.k8s.io/v1beta1
2+
kind: DeviceClass
33
metadata:
44
name: example
55
spec:

test/e2e/dra/test-driver/deploy/example/pod-external.yaml

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,19 @@
11
# One external resource claim, one pod, two containers.
22
# One container uses resource, one does not.
3-
apiVersion: v1
4-
kind: ConfigMap
5-
metadata:
6-
name: external-claim-parameters
7-
namespace: default
8-
data:
9-
a: b
10-
---
11-
apiVersion: resource.k8s.io/v1alpha3
3+
apiVersion: resource.k8s.io/v1beta1
124
kind: ResourceClaim
135
metadata:
146
name: external-claim
157
spec:
16-
resourceClassName: example
17-
parametersRef:
18-
kind: ConfigMap
19-
name: external-claim-parameters
8+
devices:
9+
requests:
10+
- name: my-device
11+
deviceClassName: example
12+
config:
13+
- opaque:
14+
driver: test-driver.cdi.k8s.io
15+
parameters:
16+
a: b
2017
---
2118
apiVersion: v1
2219
kind: Pod
@@ -30,7 +27,7 @@ spec:
3027
command: ["sh", "-c", "set && mount && ls -la /dev/"]
3128
resources:
3229
claims:
33-
- resource
30+
- name: resource
3431
- name: without-resource
3532
image: registry.k8s.io/e2e-test-images/busybox:1.29-2
3633
command: ["sh", "-c", "set && mount && ls -la /dev/"]

test/e2e/dra/test-driver/deploy/example/pod-inline-multiple.yaml

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,4 @@
1-
apiVersion: v1
2-
kind: ConfigMap
3-
metadata:
4-
name: pause-claim-parameters
5-
namespace: default
6-
data:
7-
a: b
8-
---
9-
apiVersion: resource.k8s.io/v1alpha3
1+
apiVersion: resource.k8s.io/v1beta1
102
kind: ResourceClaimTemplate
113
metadata:
124
name: pause-template
@@ -16,10 +8,15 @@ spec:
168
labels:
179
app: inline-resource
1810
spec:
19-
resourceClassName: example
20-
parametersRef:
21-
kind: ConfigMap
22-
name: pause-claim-parameters
11+
devices:
12+
requests:
13+
- name: my-device
14+
deviceClassName: example
15+
config:
16+
- opaque:
17+
driver: test-driver.cdi.k8s.io
18+
parameters:
19+
a: b
2320
---
2421
apiVersion: v1
2522
kind: Pod

test/e2e/dra/test-driver/deploy/example/pod-inline.yaml

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
# One inline resource claim, one pod, two containers.
22
# One container uses resource, one does not.
3-
apiVersion: v1
4-
kind: ConfigMap
5-
metadata:
6-
name: test-inline-claim-parameters
7-
namespace: default
8-
data:
9-
a: b
10-
---
11-
apiVersion: resource.k8s.io/v1alpha3
3+
apiVersion: resource.k8s.io/v1beta1
124
kind: ResourceClaimTemplate
135
metadata:
146
name: test-inline-claim-template
@@ -18,10 +10,15 @@ spec:
1810
labels:
1911
app: inline-resource
2012
spec:
21-
resourceClassName: example
22-
parametersRef:
23-
kind: ConfigMap
24-
name: test-inline-claim-parameters
13+
devices:
14+
requests:
15+
- name: my-device
16+
deviceClassName: example
17+
config:
18+
- opaque:
19+
driver: test-driver.cdi.k8s.io
20+
parameters:
21+
a: b
2522
---
2623
apiVersion: v1
2724
kind: Pod

test/e2e/dra/test-driver/deploy/example/pod-shared.yaml

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,20 @@
11
# One external resource claim, two pods, two containers in each pod.
22
# Pods share the same resource.
33
# One container uses resource, one does not.
4-
apiVersion: v1
5-
kind: ConfigMap
6-
metadata:
7-
name: shared-claim-parameters
8-
data:
9-
a: b
10-
---
11-
apiVersion: resource.k8s.io/v1alpha3
4+
apiVersion: resource.k8s.io/v1beta1
125
kind: ResourceClaim
136
metadata:
147
name: shared-claim
158
spec:
16-
resourceClassName: example
17-
parametersRef:
18-
kind: ConfigMap
19-
name: shared-claim-parameters
9+
devices:
10+
requests:
11+
- name: my-device
12+
deviceClassName: example
13+
config:
14+
- opaque:
15+
driver: test-driver.cdi.k8s.io
16+
parameters:
17+
a: b
2018
---
2119
apiVersion: v1
2220
kind: Pod

0 commit comments

Comments
 (0)