Refactor error handling for configz initialization

myeunee · myeunee · commit 2faaedbe39fe · 2024-10-30T04:53:51.000+09:00
Improved code readability and limited variable scope as per reviewer's suggestion.
diff --git a/cmd/kube-scheduler/app/server.go b/cmd/kube-scheduler/app/server.go
@@ -169,8 +169,7 @@ func Run(ctx context.Context, cc *schedulerserverconfig.CompletedConfig, sched *
 	logger.Info("Golang settings", "GOGC", os.Getenv("GOGC"), "GOMAXPROCS", os.Getenv("GOMAXPROCS"), "GOTRACEBACK", os.Getenv("GOTRACEBACK"))
 
 	// Configz registration.
-	cz, err := configz.New("componentconfig")
-	if err != nil {
+	if cz, err := configz.New("componentconfig"); err != nil {
 		return fmt.Errorf("unable to register configz: %s", err)
 	}
 	cz.Set(cc.ComponentConfig)

Original file line number	Diff line number	Diff line change
`@@ -169,8 +169,7 @@ func Run(ctx context.Context, cc schedulerserverconfig.CompletedConfig, sched `
`169`	`169`	`logger.Info("Golang settings", "GOGC", os.Getenv("GOGC"), "GOMAXPROCS", os.Getenv("GOMAXPROCS"), "GOTRACEBACK", os.Getenv("GOTRACEBACK"))`
`170`	`170`
`171`	`171`	`// Configz registration.`
`172`		`- cz, err := configz.New("componentconfig")`
`173`		`- if err != nil {`
	`172`	`+ if cz, err := configz.New("componentconfig"); err != nil {`
`174`	`173`	`return fmt.Errorf("unable to register configz: %s", err)`
`175`	`174`	`}`
`176`	`175`	`cz.Set(cc.ComponentConfig)`