Skip to content

Commit 37a8516

Browse files
authored
Merge pull request kubernetes#129530 from nojnhuh/dra-vap-message
Add namespace to DRA adminAccess ValidatingAdmissionPolicy message
2 parents d944121 + 5b2c1dd commit 37a8516

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

test/e2e/dra/dra.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -922,7 +922,7 @@ var _ = framework.SIGDescribe("node")("DRA", feature.DynamicResourceAllocation,
922922
claim.Spec.Devices.Requests[0].AdminAccess = ptr.To(true)
923923
_, claimTemplate := b.podInline()
924924
claimTemplate.Spec.Spec.Devices.Requests[0].AdminAccess = ptr.To(true)
925-
matchVAPError := gomega.MatchError(gomega.ContainSubstring("admin access to devices not enabled" /* in namespace " + b.f.Namespace.Name */))
925+
matchVAPError := gomega.MatchError(gomega.ContainSubstring("admin access to devices not enabled in namespace " + b.f.Namespace.Name))
926926
gomega.Eventually(ctx, func(ctx context.Context) error {
927927
// First delete, in case that it succeeded earlier.
928928
if err := b.f.ClientSet.ResourceV1beta1().ResourceClaims(b.f.Namespace.Name).Delete(ctx, claim.Name, metav1.DeleteOptions{}); err != nil && !apierrors.IsNotFound(err) {

test/e2e/dra/test-driver/deploy/example/admin-access-policy.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ spec:
2525
validations:
2626
- expression: '! object.spec.devices.requests.exists(e, has(e.adminAccess) && e.adminAccess)'
2727
reason: Forbidden
28-
messageExpression: '"admin access to devices not enabled"' # in namespace " + object.metadata.namespace' - need to use __namespace__, but somehow that also doesn't work.
28+
messageExpression: '"admin access to devices not enabled in namespace " + namespaceObject.metadata.name'
2929
---
3030
apiVersion: admissionregistration.k8s.io/v1
3131
kind: ValidatingAdmissionPolicyBinding
@@ -55,7 +55,7 @@ spec:
5555
validations:
5656
- expression: '! object.spec.spec.devices.requests.exists(e, has(e.adminAccess) && e.adminAccess)'
5757
reason: Forbidden
58-
messageExpression: '"admin access to devices not enabled"' # in namespace " + object.metadata.namespace' - need to use __namespace__, but somehow that also doesn't work.
58+
messageExpression: '"admin access to devices not enabled in namespace " + namespaceObject.metadata.name'
5959
---
6060
apiVersion: admissionregistration.k8s.io/v1
6161
kind: ValidatingAdmissionPolicyBinding

0 commit comments

Comments
 (0)