Comment on QHint for CSILimit when CSINodes are added (kubernetes#122758)

utam0k · web-flow · commit 3a4c35cc89c0 · 2024-02-02T22:16:20.000-08:00
Signed-off-by: utam0k &lt;k0ma@utam0k.jp&gt;
diff --git a/pkg/scheduler/framework/plugins/nodevolumelimits/csi.go b/pkg/scheduler/framework/plugins/nodevolumelimits/csi.go
@@ -76,6 +76,8 @@ func (pl *CSILimits) Name() string {
 // failed by this plugin schedulable.
 func (pl *CSILimits) EventsToRegister() []framework.ClusterEventWithHint {
 	return []framework.ClusterEventWithHint{
+		// We don't register any `QueueingHintFn` intentionally
+		// because any new CSINode could make pods that were rejected by CSI volumes schedulable.
 		{Event: framework.ClusterEvent{Resource: framework.CSINode, ActionType: framework.Add}},
 		{Event: framework.ClusterEvent{Resource: framework.Pod, ActionType: framework.Delete}},
 	}

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,8 @@ func (pl *CSILimits) Name() string {`
`76`	`76`	`// failed by this plugin schedulable.`
`77`	`77`	`func (pl *CSILimits) EventsToRegister() []framework.ClusterEventWithHint {`
`78`	`78`	`return []framework.ClusterEventWithHint{`
	`79`	+ // We don't register any `QueueingHintFn` intentionally
	`80`	`+ // because any new CSINode could make pods that were rejected by CSI volumes schedulable.`
`79`	`81`	`{Event: framework.ClusterEvent{Resource: framework.CSINode, ActionType: framework.Add}},`
`80`	`82`	`{Event: framework.ClusterEvent{Resource: framework.Pod, ActionType: framework.Delete}},`
`81`	`83`	`}`