Skip to content

Commit 3a620a3

Browse files
authored
Merge pull request kubernetes#126888 from aroradaman/proxy-nfacct-e2e-fix
e2e/network/proxy: fix e2e assertions
2 parents bd6f29f + 3a94249 commit 3a620a3

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

test/e2e/network/kube_proxy.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -361,12 +361,19 @@ var _ = common.SIGDescribe("KubeProxy", func() {
361361
// our target metric should be updated by now
362362
if err := wait.PollUntilContextTimeout(ctx, 10*time.Second, 2*time.Minute, true, func(_ context.Context) (bool, error) {
363363
metrics, err := metricsGrabber.GrabFromKubeProxy(ctx, nodeName)
364-
framework.ExpectNoError(err)
364+
if err != nil {
365+
return false, fmt.Errorf("failed to fetch metrics: %w", err)
366+
}
365367
targetMetricAfter, err := metrics.GetCounterMetricValue(metricName)
366-
framework.ExpectNoError(err)
368+
if err != nil {
369+
return false, fmt.Errorf("failed to fetch metric: %w", err)
370+
}
367371
return targetMetricAfter > targetMetricBefore, nil
368372
}); err != nil {
369-
framework.Failf("expected %s metric to be updated after accessing endpoints via localhost nodeports", metricName)
373+
if wait.Interrupted(err) {
374+
framework.Failf("expected %s metric to be updated after accessing endpoints via localhost nodeports", metricName)
375+
}
376+
framework.ExpectNoError(err)
370377
}
371378
})
372379
})

0 commit comments

Comments
 (0)