Skip to content

Commit 3d24b96

Browse files
authored
Merge pull request kubernetes#124505 from jsafrane/clean-pvlabeler
Remove PersistentVolumeLabel admission plugin
2 parents dfcb447 + e7a6ed2 commit 3d24b96

File tree

6 files changed

+1
-1008
lines changed

6 files changed

+1
-1008
lines changed

hack/make-rules/test-cmd.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ function run_kube_apiserver() {
5656

5757
# Admission Controllers to invoke prior to persisting objects in cluster
5858
ENABLE_ADMISSION_PLUGINS="LimitRanger,ResourceQuota"
59-
DISABLE_ADMISSION_PLUGINS="ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,StorageObjectInUseProtection"
59+
DISABLE_ADMISSION_PLUGINS="ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,StorageObjectInUseProtection"
6060

6161
# Include RBAC (to exercise bootstrapping), and AlwaysAllow to allow all actions
6262
AUTHORIZATION_MODE="RBAC,AlwaysAllow"

pkg/kubeapiserver/options/plugins.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ import (
4949
"k8s.io/kubernetes/plugin/pkg/admission/runtimeclass"
5050
"k8s.io/kubernetes/plugin/pkg/admission/security/podsecurity"
5151
"k8s.io/kubernetes/plugin/pkg/admission/serviceaccount"
52-
"k8s.io/kubernetes/plugin/pkg/admission/storage/persistentvolume/label"
5352
"k8s.io/kubernetes/plugin/pkg/admission/storage/persistentvolume/resize"
5453
"k8s.io/kubernetes/plugin/pkg/admission/storage/storageclass/setdefault"
5554
"k8s.io/kubernetes/plugin/pkg/admission/storage/storageobjectinuseprotection"
@@ -82,7 +81,6 @@ var AllOrderedPlugins = []string{
8281
podtolerationrestriction.PluginName, // PodTolerationRestriction
8382
eventratelimit.PluginName, // EventRateLimit
8483
extendedresourcetoleration.PluginName, // ExtendedResourceToleration
85-
label.PluginName, // PersistentVolumeLabel
8684
setdefault.PluginName, // DefaultStorageClass
8785
storageobjectinuseprotection.PluginName, // StorageObjectInUseProtection
8886
gc.PluginName, // OwnerReferencesPermissionEnforcement
@@ -126,7 +124,6 @@ func RegisterAllAdmissionPlugins(plugins *admission.Plugins) {
126124
exists.Register(plugins)
127125
noderestriction.Register(plugins)
128126
nodetaint.Register(plugins)
129-
label.Register(plugins) // DEPRECATED, future PVs should not rely on labels for zone topology
130127
podnodeselector.Register(plugins)
131128
podtolerationrestriction.Register(plugins)
132129
runtimeclass.Register(plugins)

plugin/pkg/admission/storage/persistentvolume/label/OWNERS

Lines changed: 0 additions & 10 deletions
This file was deleted.

plugin/pkg/admission/storage/persistentvolume/label/admission.go

Lines changed: 0 additions & 309 deletions
This file was deleted.

0 commit comments

Comments
 (0)