Skip to content

Commit 3d6c5b2

Browse files
authored
Merge pull request kubernetes#127551 from carlory/fix-trace-context
introduce a proper trace context
2 parents a8c955a + 5b2632f commit 3d6c5b2

File tree

6 files changed

+8
-0
lines changed

6 files changed

+8
-0
lines changed

staging/src/k8s.io/apiserver/pkg/endpoints/handlers/create.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ func createHandler(r rest.NamedCreater, scope *RequestScope, admit admission.Int
5555
ctx := req.Context()
5656
// For performance tracking purposes.
5757
ctx, span := tracing.Start(ctx, "Create", traceFields(req)...)
58+
req = req.WithContext(ctx)
5859
defer span.End(500 * time.Millisecond)
5960

6061
namespace, name, err := scope.Namer.Name(req)

staging/src/k8s.io/apiserver/pkg/endpoints/handlers/delete.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ func DeleteResource(r rest.GracefulDeleter, allowsOptions bool, scope *RequestSc
5252
ctx := req.Context()
5353
// For performance tracking purposes.
5454
ctx, span := tracing.Start(ctx, "Delete", traceFields(req)...)
55+
req = req.WithContext(ctx)
5556
defer span.End(500 * time.Millisecond)
5657

5758
namespace, name, err := scope.Namer.Name(req)
@@ -172,6 +173,7 @@ func DeleteCollection(r rest.CollectionDeleter, checkBody bool, scope *RequestSc
172173
return func(w http.ResponseWriter, req *http.Request) {
173174
ctx := req.Context()
174175
ctx, span := tracing.Start(ctx, "Delete", traceFields(req)...)
176+
req = req.WithContext(ctx)
175177
defer span.End(500 * time.Millisecond)
176178

177179
namespace, err := scope.Namer.Namespace(req)

staging/src/k8s.io/apiserver/pkg/endpoints/handlers/get.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ func getResourceHandler(scope *RequestScope, getter getterFunc) http.HandlerFunc
5858
return func(w http.ResponseWriter, req *http.Request) {
5959
ctx := req.Context()
6060
ctx, span := tracing.Start(ctx, "Get", traceFields(req)...)
61+
req = req.WithContext(ctx)
6162
defer span.End(500 * time.Millisecond)
6263

6364
namespace, name, err := scope.Namer.Name(req)
@@ -172,6 +173,7 @@ func ListResource(r rest.Lister, rw rest.Watcher, scope *RequestScope, forceWatc
172173
ctx := req.Context()
173174
// For performance tracking purposes.
174175
ctx, span := tracing.Start(ctx, "List", traceFields(req)...)
176+
req = req.WithContext(ctx)
175177

176178
namespace, err := scope.Namer.Namespace(req)
177179
if err != nil {

staging/src/k8s.io/apiserver/pkg/endpoints/handlers/patch.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ func PatchResource(r rest.Patcher, scope *RequestScope, admit admission.Interfac
6666
ctx := req.Context()
6767
// For performance tracking purposes.
6868
ctx, span := tracing.Start(ctx, "Patch", traceFields(req)...)
69+
req = req.WithContext(ctx)
6970
defer span.End(500 * time.Millisecond)
7071

7172
// Do this first, otherwise name extraction can fail for unrecognized content types

staging/src/k8s.io/apiserver/pkg/endpoints/handlers/responsewriters/writers.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ func SerializeObject(mediaType string, encoder runtime.Encoder, hw http.Response
9898
attribute.String("protocol", req.Proto),
9999
attribute.String("mediaType", mediaType),
100100
attribute.String("encoder", string(encoder.Identifier())))
101+
req = req.WithContext(ctx)
101102
defer span.End(5 * time.Second)
102103

103104
w := &deferredResponseWriter{

staging/src/k8s.io/apiserver/pkg/endpoints/handlers/update.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ func UpdateResource(r rest.Updater, scope *RequestScope, admit admission.Interfa
5353
ctx := req.Context()
5454
// For performance tracking purposes.
5555
ctx, span := tracing.Start(ctx, "Update", traceFields(req)...)
56+
req = req.WithContext(ctx)
5657
defer span.End(500 * time.Millisecond)
5758

5859
namespace, name, err := scope.Namer.Name(req)

0 commit comments

Comments
 (0)