Merge pull request kubernetes#129252 from liggitt/path-warnings

k8s-ci-robot · web-flow · commit 3fb2a38cd271 · 2024-12-17T16:14:52.000+01:00
Use OS-agnostic path separator in pod warnings check
diff --git a/pkg/api/pod/warnings.go b/pkg/api/pod/warnings.go
@@ -515,7 +515,7 @@ func checkVolumeMappingForOverlap(paths []pathAndSource) []string {
 }
 
 func checkForOverlap(haystack []pathAndSource, needle pathAndSource) []pathAndSource {
-	pathSeparator := string(os.PathSeparator)
+	pathSeparator := `/` // this check runs in the API server, use the OS-agnostic separator
 
 	if needle.path == "" {
 		return nil

Original file line number	Diff line number	Diff line change
`@@ -515,7 +515,7 @@ func checkVolumeMappingForOverlap(paths []pathAndSource) []string {`
`515`	`515`	`}`
`516`	`516`
`517`	`517`	`func checkForOverlap(haystack []pathAndSource, needle pathAndSource) []pathAndSource {`
`518`		`- pathSeparator := string(os.PathSeparator)`
	`518`	+ pathSeparator := `/` // this check runs in the API server, use the OS-agnostic separator
`519`	`519`
`520`	`520`	`if needle.path == "" {`
`521`	`521`	`return nil`