Skip to content

Commit 48dc7d3

Browse files
committed
add TODO for image fs
1 parent 742ca47 commit 48dc7d3

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

pkg/kubelet/eviction/eviction_manager.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,12 +254,16 @@ func (m *managerImpl) synchronize(diskInfoProvider DiskInfoProvider, podFunc Act
254254
if m.dedicatedImageFs == nil {
255255
hasImageFs, imageFsErr := diskInfoProvider.HasDedicatedImageFs(ctx)
256256
if imageFsErr != nil {
257+
// TODO: This should be refactored to log an error and retry the HasDedicatedImageFs
258+
// If we have a transient error this will never be retried and we will not set eviction signals
257259
klog.ErrorS(imageFsErr, "Eviction manager: failed to get HasDedicatedImageFs")
258260
return nil, fmt.Errorf("eviction manager: failed to get HasDedicatedImageFs: %w", imageFsErr)
259261
}
260262
m.dedicatedImageFs = &hasImageFs
261263
splitContainerImageFs, splitErr := diskInfoProvider.HasDedicatedContainerFs(ctx)
262264
if splitErr != nil {
265+
// A common error case is when there is no split filesystem
266+
// there is an error finding the split filesystem label and we want to ignore these errors
263267
klog.ErrorS(splitErr, "eviction manager: failed to check if we have separate container filesystem. Ignoring.")
264268
}
265269

0 commit comments

Comments
 (0)