Skip to content

Commit 4a5bbc4

Browse files
committed
Flip SeparateCacheWatchRPC feature gate to false and deprecate it.
Watch requests to etcd are mapped to a single stream that has a limited throughput. By opening a lot of concurrent watch requests to single resource, users could starve other watches from getting any events. Separating the RPC was meant to protect the watch opened by cache. However, as we are no longer planning to allow users to open watch directly to etcd, the flag is not needed.
1 parent 3bc8f01 commit 4a5bbc4

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

pkg/features/versioned_kube_features.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate
325325

326326
genericfeatures.SeparateCacheWatchRPC: {
327327
{Version: version.MustParse("1.28"), Default: true, PreRelease: featuregate.Beta},
328+
{Version: version.MustParse("1.33"), Default: false, PreRelease: featuregate.Deprecated},
328329
},
329330

330331
genericfeatures.StorageVersionAPI: {

staging/src/k8s.io/apiserver/pkg/features/kube_features.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,7 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate
364364

365365
SeparateCacheWatchRPC: {
366366
{Version: version.MustParse("1.28"), Default: true, PreRelease: featuregate.Beta},
367+
{Version: version.MustParse("1.33"), Default: false, PreRelease: featuregate.Deprecated},
367368
},
368369

369370
StorageVersionAPI: {

test/featuregates_linter/test_data/versioned_feature_list.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1150,6 +1150,10 @@
11501150
lockToDefault: false
11511151
preRelease: Beta
11521152
version: "1.28"
1153+
- default: false
1154+
lockToDefault: false
1155+
preRelease: Deprecated
1156+
version: "1.33"
11531157
- name: SeparateTaintEvictionController
11541158
versionedSpecs:
11551159
- default: true

0 commit comments

Comments
 (0)