Skip to content

Commit 4aeedcd

Browse files
committed
Fix CSI migration UTs
1 parent 14936a7 commit 4aeedcd

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

pkg/volume/csimigration/plugin_manager_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"testing"
2222

2323
v1 "k8s.io/api/core/v1"
24+
"k8s.io/apimachinery/pkg/util/version"
2425
utilfeature "k8s.io/apiserver/pkg/util/feature"
2526
"k8s.io/component-base/featuregate"
2627
featuregatetesting "k8s.io/component-base/featuregate/testing"
@@ -79,6 +80,8 @@ func TestIsMigratable(t *testing.T) {
7980
for _, test := range testCases {
8081
pm := NewPluginManager(csiTranslator, utilfeature.DefaultFeatureGate)
8182
t.Run(fmt.Sprintf("Testing %v", test.name), func(t *testing.T) {
83+
// TODO: this will be removed in 1.36
84+
featuregatetesting.SetFeatureGateEmulationVersionDuringTest(t, utilfeature.DefaultFeatureGate, version.MustParse("1.32"))
8285
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, test.pluginFeature, test.pluginFeatureEnabled)
8386
migratable, err := pm.IsMigratable(test.spec)
8487
if migratable != test.isMigratable {
@@ -147,6 +150,8 @@ func TestMigrationFeatureFlagStatus(t *testing.T) {
147150
for _, test := range testCases {
148151
pm := NewPluginManager(csiTranslator, utilfeature.DefaultFeatureGate)
149152
t.Run(fmt.Sprintf("Testing %v", test.name), func(t *testing.T) {
153+
// TODO: this will be removed in 1.36
154+
featuregatetesting.SetFeatureGateEmulationVersionDuringTest(t, utilfeature.DefaultFeatureGate, version.MustParse("1.32"))
150155
if len(test.pluginFeature) > 0 {
151156
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, test.pluginFeature, test.pluginFeatureEnabled)
152157
}

0 commit comments

Comments
 (0)