Skip to content

Commit 4c522bf

Browse files
committed
remove unnecessary dependency on k8s.io/api
1 parent 5ecd83f commit 4c522bf

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

staging/src/k8s.io/api/go.mod

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ godebug default=go1.23
88

99
require (
1010
github.com/gogo/protobuf v1.3.2
11-
github.com/stretchr/testify v1.9.0
1211
k8s.io/apimachinery v0.0.0
1312
)
1413

@@ -23,7 +22,6 @@ require (
2322
github.com/kr/pretty v0.3.1 // indirect
2423
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
2524
github.com/modern-go/reflect2 v1.0.2 // indirect
26-
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
2725
github.com/rogpeppe/go-internal v1.12.0 // indirect
2826
github.com/spf13/pflag v1.0.5 // indirect
2927
github.com/x448/float16 v0.8.4 // indirect
@@ -33,7 +31,6 @@ require (
3331
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect
3432
gopkg.in/inf.v0 v0.9.1 // indirect
3533
gopkg.in/yaml.v2 v2.4.0 // indirect
36-
gopkg.in/yaml.v3 v3.0.1 // indirect
3734
k8s.io/klog/v2 v2.130.1 // indirect
3835
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 // indirect
3936
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect

staging/src/k8s.io/api/go.sum

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/api/roundtrip_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ import (
7878
storagev1beta1 "k8s.io/api/storage/v1beta1"
7979
svmv1alpha1 "k8s.io/api/storagemigration/v1alpha1"
8080

81-
"github.com/stretchr/testify/require"
8281
"k8s.io/apimachinery/pkg/api/apitesting/fuzzer"
8382
"k8s.io/apimachinery/pkg/api/apitesting/roundtrip"
8483
genericfuzzer "k8s.io/apimachinery/pkg/apis/meta/fuzzer"
@@ -150,7 +149,9 @@ func TestRoundTripExternalTypes(t *testing.T) {
150149
scheme := runtime.NewScheme()
151150
codecs := serializer.NewCodecFactory(scheme)
152151
for _, builder := range groups {
153-
require.NoError(t, builder.AddToScheme(scheme))
152+
if err := builder.AddToScheme(scheme); err != nil {
153+
t.Fatalf("unexpected error adding to scheme: %v", err)
154+
}
154155
}
155156
seed := rand.Int63()
156157
// I'm only using the generic fuzzer funcs, but at some point in time we might need to
@@ -163,7 +164,9 @@ func TestRoundTripExternalTypes(t *testing.T) {
163164
func TestCompatibility(t *testing.T) {
164165
scheme := runtime.NewScheme()
165166
for _, builder := range groups {
166-
require.NoError(t, builder.AddToScheme(scheme))
167+
if err := builder.AddToScheme(scheme); err != nil {
168+
t.Fatalf("unexpected error adding to scheme: %v", err)
169+
}
167170
}
168171
roundtrip.NewCompatibilityTestOptions(scheme).Complete(t).Run(t)
169172
}

0 commit comments

Comments
 (0)