Skip to content

Commit 4d5264f

Browse files
committed
logging benchmark: support slog
Replacing zapr with slog as JSON implementation can be benchmarked by replacing "false" with "true" and rerunning. However, slog is slower: Encoding/error-value/JSON-36 171k ± 3% 148k ± 5% -13.64% (p=0.008 n=5+5) Encoding/error/JSON-36 207k ± 9% 149k ± 4% -27.87% (p=0.008 n=5+5) Encoding/kind-worker-kubelet/JSON-36 348k ± 2% 334k ± 1% -4.13% (p=0.008 n=5+5) Encoding/kube-apiserver/JSON-36 210k ± 2% 186k ± 1% -11.53% (p=0.008 n=5+5) Encoding/kube-controller-manager/JSON-36 291k ± 1% 249k ± 2% -14.26% (p=0.008 n=5+5) Encoding/kube-scheduler/JSON-36 262k ± 4% 223k ± 2% -14.91% (p=0.008 n=5+5) Encoding/simple/JSON-36 161k ± 4% 132k ± 2% -17.60% (p=0.008 n=5+5) Encoding/split/JSON-36 159k ± 4% 132k ± 1% -17.23% (p=0.008 n=5+5) Encoding/v3/kind-worker-kubelet/JSON-36 255k ± 1% 256k ± 1% ~ (p=0.222 n=5+5) Encoding/v3/kube-apiserver/JSON-36 131k ± 4% 105k ± 4% -20.07% (p=0.008 n=5+5) Encoding/v3/kube-controller-manager/JSON-36 285k ± 2% 250k ± 2% -12.13% (p=0.008 n=5+5) Encoding/v3/kube-scheduler/JSON-36 216k ± 3% 196k ± 4% -9.63% (p=0.008 n=5+5)
1 parent 40c4015 commit 4d5264f

File tree

1 file changed

+40
-0
lines changed

1 file changed

+40
-0
lines changed

test/integration/logs/benchmark/benchmark_test.go

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"errors"
2121
"io"
2222
"io/fs"
23+
"log/slog"
2324
"os"
2425
"path/filepath"
2526
"regexp"
@@ -29,6 +30,8 @@ import (
2930
"testing"
3031
"time"
3132

33+
"github.com/go-logr/logr"
34+
"go.uber.org/zap/zapcore"
3235
"k8s.io/component-base/featuregate"
3336
logsapi "k8s.io/component-base/logs/api/v1"
3437
_ "k8s.io/component-base/logs/json/register"
@@ -93,6 +96,43 @@ func BenchmarkEncoding(b *testing.B) {
9396
b.Fatalf("Unexpected error configuring logging: %v", err)
9497
}
9598
logger := klog.Background()
99+
100+
// Edit and run with this if branch enabled to use slog instead of zapr for JSON.
101+
if format == "json" && false {
102+
var level slog.LevelVar
103+
level.Set(slog.Level(-3)) // hack
104+
logger = logr.FromSlogHandler(slog.NewJSONHandler(output, &slog.HandlerOptions{
105+
AddSource: true,
106+
Level: &level,
107+
ReplaceAttr: func(groups []string, a slog.Attr) slog.Attr {
108+
switch a.Key {
109+
case slog.TimeKey:
110+
// Could be user-supplied "time".
111+
if a.Value.Kind() == slog.KindTime {
112+
return slog.Float64("ts", float64(a.Value.Time().UnixMicro())/1000)
113+
}
114+
case slog.LevelKey:
115+
level := a.Value.Any().(slog.Level)
116+
if level >= slog.LevelError {
117+
// No verbosity on errors.
118+
return slog.Attr{}
119+
}
120+
if level >= 0 {
121+
return slog.Int("v", 0)
122+
}
123+
return slog.Int("v", int(-level))
124+
case slog.SourceKey:
125+
caller := zapcore.EntryCaller{
126+
Defined: true,
127+
File: a.Value.String(),
128+
}
129+
return slog.String("caller", caller.TrimmedPath())
130+
}
131+
return a
132+
},
133+
}))
134+
}
135+
96136
b.ResetTimer()
97137
start := time.Now()
98138
total := int64(0)

0 commit comments

Comments
 (0)