@@ -21,6 +21,7 @@ import (
21
21
"fmt"
22
22
"os"
23
23
"reflect"
24
+ goruntime "runtime"
24
25
"strings"
25
26
"testing"
26
27
@@ -1896,6 +1897,13 @@ func TestRemoveContainer(t *testing.T) {
1896
1897
}
1897
1898
}
1898
1899
1900
+ func getPolicyNameForOs () policyType {
1901
+ if goruntime .GOOS == "windows" {
1902
+ return policyTypeBestEffort
1903
+ }
1904
+ return policyTypeStatic
1905
+ }
1906
+
1899
1907
func TestNewManager (t * testing.T ) {
1900
1908
machineInfo := returnMachineInfo ()
1901
1909
expectedReserved := systemReservedMemory {
@@ -1909,7 +1917,7 @@ func TestNewManager(t *testing.T) {
1909
1917
testCases := []testMemoryManager {
1910
1918
{
1911
1919
description : "Successful creation of Memory Manager instance" ,
1912
- policyName : policyTypeStatic ,
1920
+ policyName : getPolicyNameForOs () ,
1913
1921
machineInfo : machineInfo ,
1914
1922
nodeAllocatableReservation : v1.ResourceList {v1 .ResourceMemory : * resource .NewQuantity (2 * gb , resource .BinarySI )},
1915
1923
systemReservedMemory : []kubeletconfig.MemoryReservation {
@@ -1928,7 +1936,7 @@ func TestNewManager(t *testing.T) {
1928
1936
},
1929
1937
{
1930
1938
description : "Should return an error when systemReservedMemory (configured with kubelet flag) does not comply with Node Allocatable feature values" ,
1931
- policyName : policyTypeStatic ,
1939
+ policyName : getPolicyNameForOs () ,
1932
1940
machineInfo : machineInfo ,
1933
1941
nodeAllocatableReservation : v1.ResourceList {v1 .ResourceMemory : * resource .NewQuantity (2 * gb , resource .BinarySI )},
1934
1942
systemReservedMemory : []kubeletconfig.MemoryReservation {
@@ -1951,7 +1959,7 @@ func TestNewManager(t *testing.T) {
1951
1959
},
1952
1960
{
1953
1961
description : "Should return an error when memory reserved for system is empty (systemReservedMemory)" ,
1954
- policyName : policyTypeStatic ,
1962
+ policyName : getPolicyNameForOs () ,
1955
1963
machineInfo : machineInfo ,
1956
1964
nodeAllocatableReservation : v1.ResourceList {},
1957
1965
systemReservedMemory : []kubeletconfig.MemoryReservation {},
0 commit comments