Skip to content

Commit 5918559

Browse files
committed
sample controller: enhance context support
27a68ae introduced context support for events. Creating an event broadcaster with context makes tests more resilient against leaking goroutines when that context gets canceled at the end of a test and enables per-test output via ktesting. The New method already had a context, therefore no API changes are needed.
1 parent a9eded0 commit 5918559

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

staging/src/k8s.io/sample-controller/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ func NewController(
101101
utilruntime.Must(samplescheme.AddToScheme(scheme.Scheme))
102102
logger.V(4).Info("Creating event broadcaster")
103103

104-
eventBroadcaster := record.NewBroadcaster()
104+
eventBroadcaster := record.NewBroadcaster(record.WithContext(ctx))
105105
eventBroadcaster.StartStructuredLogging(0)
106106
eventBroadcaster.StartRecordingToSink(&typedcorev1.EventSinkImpl{Interface: kubeclientset.CoreV1().Events("")})
107107
recorder := eventBroadcaster.NewRecorder(scheme.Scheme, corev1.EventSource{Component: controllerAgentName})

0 commit comments

Comments
 (0)