Skip to content

Commit 5cc6f66

Browse files
authored
Merge pull request kubernetes#129070 from zhifei92/fix-typo
e2e_node: Simplify the code logic
2 parents b21ab17 + cb74323 commit 5cc6f66

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

test/e2e/framework/pod/wait.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ func WaitForPodScheduled(ctx context.Context, c clientset.Interface, namespace,
801801
func WaitForPodContainerStarted(ctx context.Context, c clientset.Interface, namespace, podName string, containerIndex int, timeout time.Duration) error {
802802
conditionDesc := fmt.Sprintf("container %d started", containerIndex)
803803
return WaitForPodCondition(ctx, c, namespace, podName, conditionDesc, timeout, func(pod *v1.Pod) (bool, error) {
804-
if containerIndex > len(pod.Status.ContainerStatuses)-1 {
804+
if containerIndex >= len(pod.Status.ContainerStatuses) {
805805
return false, nil
806806
}
807807
containerStatus := pod.Status.ContainerStatuses[containerIndex]
@@ -813,7 +813,7 @@ func WaitForPodContainerStarted(ctx context.Context, c clientset.Interface, name
813813
func WaitForPodInitContainerStarted(ctx context.Context, c clientset.Interface, namespace, podName string, initContainerIndex int, timeout time.Duration) error {
814814
conditionDesc := fmt.Sprintf("init container %d started", initContainerIndex)
815815
return WaitForPodCondition(ctx, c, namespace, podName, conditionDesc, timeout, func(pod *v1.Pod) (bool, error) {
816-
if initContainerIndex > len(pod.Status.InitContainerStatuses)-1 {
816+
if initContainerIndex >= len(pod.Status.InitContainerStatuses) {
817817
return false, nil
818818
}
819819
initContainerStatus := pod.Status.InitContainerStatuses[initContainerIndex]

test/e2e_node/util.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,7 @@ func getPidFromPidFile(pidFile string) (int, error) {
577577
func WaitForPodInitContainerRestartCount(ctx context.Context, c clientset.Interface, namespace, podName string, initContainerIndex int, desiredRestartCount int32, timeout time.Duration) error {
578578
conditionDesc := fmt.Sprintf("init container %d started", initContainerIndex)
579579
return e2epod.WaitForPodCondition(ctx, c, namespace, podName, conditionDesc, timeout, func(pod *v1.Pod) (bool, error) {
580-
if initContainerIndex > len(pod.Status.InitContainerStatuses)-1 {
580+
if initContainerIndex >= len(pod.Status.InitContainerStatuses) {
581581
return false, nil
582582
}
583583
containerStatus := pod.Status.InitContainerStatuses[initContainerIndex]
@@ -590,7 +590,7 @@ func WaitForPodInitContainerRestartCount(ctx context.Context, c clientset.Interf
590590
func WaitForPodContainerRestartCount(ctx context.Context, c clientset.Interface, namespace, podName string, containerIndex int, desiredRestartCount int32, timeout time.Duration) error {
591591
conditionDesc := fmt.Sprintf("container %d started", containerIndex)
592592
return e2epod.WaitForPodCondition(ctx, c, namespace, podName, conditionDesc, timeout, func(pod *v1.Pod) (bool, error) {
593-
if containerIndex > len(pod.Status.ContainerStatuses)-1 {
593+
if containerIndex >= len(pod.Status.ContainerStatuses) {
594594
return false, nil
595595
}
596596
containerStatus := pod.Status.ContainerStatuses[containerIndex]

0 commit comments

Comments
 (0)