Apply feedback

jpbetz · jpbetz · commit 5db9eff04f16 · 2024-06-04T15:25:02.000-04:00
diff --git a/test/integration/apiserver/apply/apply_test.go b/test/integration/apiserver/apply/apply_test.go
@@ -299,7 +299,8 @@ func TestNoOpApplyWithEmptyMap(t *testing.T) {
 		t.Fatalf("Failed to create object: %v", err)
 	}
 
-	// Sleep for one second to make sure that the times of each update operation is different.
+	// This sleep is necessary to consistently produce different timestamps because the time field in managedFields has
+	// 1 second granularity and if both apply requests happen during the same second, this test would flake.
 	time.Sleep(1 * time.Second)
 
 	createdObject, err := client.AppsV1().RESTClient().Get().Namespace("default").Resource(deploymentsResource).Name(deploymentName).Do(context.TODO()).Get()

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,8 @@ func TestNoOpApplyWithEmptyMap(t *testing.T) {`
`299`	`299`	`t.Fatalf("Failed to create object: %v", err)`
`300`	`300`	`}`
`301`	`301`
`302`		`- // Sleep for one second to make sure that the times of each update operation is different.`
	`302`	`+ // This sleep is necessary to consistently produce different timestamps because the time field in managedFields has`
	`303`	`+ // 1 second granularity and if both apply requests happen during the same second, this test would flake.`
`303`	`304`	`time.Sleep(1 * time.Second)`
`304`	`305`
`305`	`306`	`createdObject, err := client.AppsV1().RESTClient().Get().Namespace("default").Resource(deploymentsResource).Name(deploymentName).Do(context.TODO()).Get()`