[KEP-4817] Remove unnecessary DeepCopy in validation tests

Signed-off-by: Lionel Jouin <[email protected]>

Author: LionelJouin

pkg/apis/resource/validation/validation_resourceclaim_test.go

@@ -988,7 +988,6 @@ func TestValidateClaimStatusUpdate(t *testing.T) {
 		"valid-network-device-status": {
 			oldClaim: func() *resource.ResourceClaim { return validAllocatedClaim }(),
 			update: func(claim *resource.ResourceClaim) *resource.ResourceClaim {
-				claim = claim.DeepCopy()
 				claim.Status.Devices = []resource.AllocatedDeviceStatus{
 					{
 						Driver: goodName,
@@ -1023,7 +1022,6 @@ func TestValidateClaimStatusUpdate(t *testing.T) {
 			},
 			oldClaim: func() *resource.ResourceClaim { return validAllocatedClaim }(),
 			update: func(claim *resource.ResourceClaim) *resource.ResourceClaim {
-				claim = claim.DeepCopy()
 				claim.Status.Devices = []resource.AllocatedDeviceStatus{
 					{
 						Driver: goodName,
@@ -1046,7 +1044,6 @@ func TestValidateClaimStatusUpdate(t *testing.T) {
 			},
 			oldClaim: func() *resource.ResourceClaim { return validAllocatedClaim }(),
 			update: func(claim *resource.ResourceClaim) *resource.ResourceClaim {
-				claim = claim.DeepCopy()
 				claim.Status.Devices = []resource.AllocatedDeviceStatus{
 					{
 						Driver: goodName,
@@ -1069,7 +1066,6 @@ func TestValidateClaimStatusUpdate(t *testing.T) {
 			},
 			oldClaim: func() *resource.ResourceClaim { return validAllocatedClaim }(),
 			update: func(claim *resource.ResourceClaim) *resource.ResourceClaim {
-				claim = claim.DeepCopy()
 				claim.Status.Devices = []resource.AllocatedDeviceStatus{
 					{
 						Driver: goodName,
@@ -1090,7 +1086,6 @@ func TestValidateClaimStatusUpdate(t *testing.T) {
 			},
 			oldClaim: func() *resource.ResourceClaim { return validAllocatedClaim }(),
 			update: func(claim *resource.ResourceClaim) *resource.ResourceClaim {
-				claim = claim.DeepCopy()
 				claim.Status.Devices = []resource.AllocatedDeviceStatus{
 					{
 						Driver: "b",
@@ -1106,7 +1101,6 @@ func TestValidateClaimStatusUpdate(t *testing.T) {
 			wantFailures: nil,
 			oldClaim:     func() *resource.ResourceClaim { return validAllocatedClaim }(),
 			update: func(claim *resource.ResourceClaim) *resource.ResourceClaim {
-				claim = claim.DeepCopy()
 				claim.Status.Devices = []resource.AllocatedDeviceStatus{
 					{
 						Driver: goodName,
@@ -1127,7 +1121,6 @@ func TestValidateClaimStatusUpdate(t *testing.T) {
 			wantFailures: nil,
 			oldClaim:     func() *resource.ResourceClaim { return validAllocatedClaim }(),
 			update: func(claim *resource.ResourceClaim) *resource.ResourceClaim {
-				claim = claim.DeepCopy()
 				claim.Status.Devices = []resource.AllocatedDeviceStatus{
 					{
 						Driver: goodName,
@@ -1148,7 +1141,6 @@ func TestValidateClaimStatusUpdate(t *testing.T) {
 			wantFailures: nil,
 			oldClaim:     func() *resource.ResourceClaim { return validAllocatedClaim }(),
 			update: func(claim *resource.ResourceClaim) *resource.ResourceClaim {
-				claim = claim.DeepCopy()
 				claim.Status.Devices = []resource.AllocatedDeviceStatus{
 					{
 						Driver: goodName,
@@ -1167,7 +1159,6 @@ func TestValidateClaimStatusUpdate(t *testing.T) {
 			wantFailures: nil,
 			oldClaim:     func() *resource.ResourceClaim { return validAllocatedClaim }(),
 			update: func(claim *resource.ResourceClaim) *resource.ResourceClaim {
-				claim = claim.DeepCopy()
 				claim.Status.Devices = []resource.AllocatedDeviceStatus{
 					{
 						Driver: "b",