Merge pull request kubernetes#128119 from saschagrunert/api-validation-err

k8s-ci-robot · web-flow · commit 5f3316fe238a · 2024-10-21T19:44:59.000+01:00
Clarify API validation error for toleration if `operator` is `Exists` and `value` is not empty
diff --git a/pkg/apis/core/validation/validation.go b/pkg/apis/core/validation/validation.go
@@ -3990,7 +3990,7 @@ func ValidateTolerations(tolerations []core.Toleration, fldPath *field.Path) fie
 			}
 		case core.TolerationOpExists:
 			if len(toleration.Value) > 0 {
-				allErrors = append(allErrors, field.Invalid(idxPath.Child("operator"), toleration, "value must be empty when `operator` is 'Exists'"))
+				allErrors = append(allErrors, field.Invalid(idxPath.Child("operator"), toleration.Value, "value must be empty when `operator` is 'Exists'"))
 			}
 		default:
 			validValues := []core.TolerationOperator{core.TolerationOpEqual, core.TolerationOpExists}

Original file line number	Diff line number	Diff line change
`@@ -3990,7 +3990,7 @@ func ValidateTolerations(tolerations []core.Toleration, fldPath *field.Path) fie`
`3990`	`3990`	`}`
`3991`	`3991`	`case core.TolerationOpExists:`
`3992`	`3992`	`if len(toleration.Value) > 0 {`
`3993`		- allErrors = append(allErrors, field.Invalid(idxPath.Child("operator"), toleration, "value must be empty when `operator` is 'Exists'"))
	`3993`	+ allErrors = append(allErrors, field.Invalid(idxPath.Child("operator"), toleration.Value, "value must be empty when `operator` is 'Exists'"))
`3994`	`3994`	`}`
`3995`	`3995`	`default:`
`3996`	`3996`	`validValues := []core.TolerationOperator{core.TolerationOpEqual, core.TolerationOpExists}`