Skip to content

Commit 617f213

Browse files
committed
e2e: avoid redundant labels in JUnit file
Because labels are currently typically added also to the spec texts, we don't need to write them separately. This redundancy got introduced in f2cfbf4 when registering all inline tags also as labels.
1 parent 5ce0bd9 commit 617f213

File tree

1 file changed

+4
-0
lines changed
  • test/e2e/framework/internal/junit

1 file changed

+4
-0
lines changed

test/e2e/framework/internal/junit/junit.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ func WriteJUnitReport(report ginkgo.Report, filename string) error {
3636
// both, then tools like kettle and spyglass would concatenate
3737
// the two strings and thus show duplicated information.
3838
OmitFailureMessageAttr: true,
39+
40+
// All labels are also part of the spec texts in inline [] tags,
41+
// so we don't need to write them separately.
42+
OmitSpecLabels: true,
3943
}
4044

4145
return reporters.GenerateJUnitReportWithConfig(report, filename, config)

0 commit comments

Comments
 (0)