Skip to content

Commit 6552f27

Browse files
committed
use default flags for apiserver on integration tests
1 parent a1e43b4 commit 6552f27

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+115
-115
lines changed

test/integration/apimachinery/watch_timeout_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ func websocketConfig(url *url.URL, config *restclient.Config, protocols []string
9898

9999
func TestWebsocketWatchClientTimeout(t *testing.T) {
100100
// server setup
101-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, framework.SharedEtcd())
101+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
102102
defer server.TearDownFn()
103103

104104
// object setup
@@ -199,7 +199,7 @@ func TestWebsocketWatchClientTimeout(t *testing.T) {
199199

200200
func TestWatchClientTimeoutXXX(t *testing.T) {
201201
// server setup
202-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, framework.SharedEtcd())
202+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
203203
defer server.TearDownFn()
204204

205205
t.Run("direct", func(t *testing.T) {

test/integration/apiserver/admissionwebhook/broken_webhook_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func TestBrokenWebhook(t *testing.T) {
4545
}()
4646

4747
etcdConfig := framework.SharedEtcd()
48-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, etcdConfig)
48+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), etcdConfig)
4949
tearDownFn = server.TearDownFn
5050

5151
client, err := kubernetes.NewForConfig(server.ClientConfig)
@@ -80,7 +80,7 @@ func TestBrokenWebhook(t *testing.T) {
8080
t.Logf("Restarting apiserver")
8181
tearDownFn = nil
8282
server.TearDownFn()
83-
server = kubeapiservertesting.StartTestServerOrDie(t, nil, nil, etcdConfig)
83+
server = kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), etcdConfig)
8484
tearDownFn = server.TearDownFn
8585

8686
client, err = kubernetes.NewForConfig(server.ClientConfig)

test/integration/apiserver/apiserver_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ func Test4xxStatusCodeInvalidPatch(t *testing.T) {
219219
}
220220

221221
func TestCacheControl(t *testing.T) {
222-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, framework.SharedEtcd())
222+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
223223
defer server.TearDownFn()
224224

225225
rt, err := restclient.TransportFor(server.ClientConfig)
@@ -2749,7 +2749,7 @@ func expectPartialObjectMetaV1EventsProtobuf(t *testing.T, r io.Reader, values .
27492749
func TestClientsetShareTransport(t *testing.T) {
27502750
var counter int
27512751
var mu sync.Mutex
2752-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, framework.SharedEtcd())
2752+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
27532753
defer server.TearDownFn()
27542754

27552755
dialFn := func(ctx context.Context, network, address string) (net.Conn, error) {
@@ -2806,7 +2806,7 @@ func TestClientsetShareTransport(t *testing.T) {
28062806
}
28072807

28082808
func TestDedupOwnerReferences(t *testing.T) {
2809-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, framework.SharedEtcd())
2809+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
28102810
defer server.TearDownFn()
28112811
etcd.CreateTestCRDs(t, apiextensionsclient.NewForConfigOrDie(server.ClientConfig), false, etcd.GetCustomResourceDefinitionData()[0])
28122812

test/integration/apiserver/apply/apply_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ import (
4949

5050
func setup(t testing.TB) (clientset.Interface, kubeapiservertesting.TearDownFunc) {
5151
// Disable ServiceAccount admission plugin as we don't have serviceaccount controller running.
52-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, []string{"--disable-admission-plugins=ServiceAccount"}, framework.SharedEtcd())
52+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
5353

5454
config := restclient.CopyConfig(server.ClientConfig)
5555
// There are some tests (in scale_test.go) that rely on the response to be returned in JSON.

test/integration/apiserver/cve_2021_29923_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func gvr(g, v, r string) schema.GroupVersionResource {
3939
// xref: https://issues.k8s.io/100895
4040
func TestCanaryCVE_2021_29923(t *testing.T) {
4141
// Disable ServiceAccount admission plugin as we don't have serviceaccount controller running.
42-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, []string{"--disable-admission-plugins=ServiceAccount"}, framework.SharedEtcd())
42+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
4343
defer server.TearDownFn()
4444

4545
client, err := clientset.NewForConfig(server.ClientConfig)

test/integration/apiserver/discovery/discovery_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ func init() {
160160
func setup(t *testing.T) (context.Context, testClientSet, context.CancelFunc) {
161161
ctx, cancelCtx := context.WithCancel(context.Background())
162162

163-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, framework.SharedEtcd())
163+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
164164
t.Cleanup(server.TearDownFn)
165165

166166
kubeClientSet, err := kubernetes.NewForConfig(server.ClientConfig)

test/integration/apiserver/openapi/openapi_apiservice_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ func TestSlowAPIServiceOpenAPIDoesNotBlockHealthCheck(t *testing.T) {
4444
defer cancelCtx()
4545

4646
etcd := framework.SharedEtcd()
47-
setupServer := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, etcd)
47+
setupServer := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), etcd)
4848
client := generateTestClient(t, setupServer)
4949

5050
service := testdiscovery.NewFakeService("test-server", client, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -81,7 +81,7 @@ func TestSlowAPIServiceOpenAPIDoesNotBlockHealthCheck(t *testing.T) {
8181
require.NoError(t, registerAPIService(ctx, client, groupVersion, service))
8282

8383
setupServer.TearDownFn()
84-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, etcd)
84+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), etcd)
8585
t.Cleanup(server.TearDownFn)
8686
client2 := generateTestClient(t, server)
8787

@@ -100,7 +100,7 @@ func TestFetchingOpenAPIBeforeReady(t *testing.T) {
100100
ctx, cancelCtx := context.WithCancel(context.Background())
101101
defer cancelCtx()
102102

103-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, framework.SharedEtcd())
103+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
104104
t.Cleanup(server.TearDownFn)
105105
client := generateTestClient(t, server)
106106

test/integration/apiserver/portforward/portforward_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ func TestPortforward(t *testing.T) {
7979
backendPort, _ := strconv.Atoi(backendURL.Port())
8080

8181
etcd := framework.SharedEtcd()
82-
server := kastesting.StartTestServerOrDie(t, nil, []string{"--disable-admission-plugins=ServiceAccount"}, etcd)
82+
server := kastesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), etcd)
8383
defer server.TearDownFn()
8484

8585
adminClient, err := kubernetes.NewForConfig(server.ClientConfig)

test/integration/certificates/duration_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ import (
5353
func TestCSRDuration(t *testing.T) {
5454
t.Parallel()
5555

56-
s := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, framework.SharedEtcd())
56+
s := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
5757
t.Cleanup(s.TearDownFn)
5858

5959
_, ctx := ktesting.NewTestContext(t)

test/integration/certificates/field_selector_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import (
3636

3737
// Verifies that the 'spec.signerName' field can be correctly used as a field selector on LIST requests
3838
func TestCSRSignerNameFieldSelector(t *testing.T) {
39-
server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, framework.SharedEtcd())
39+
server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd())
4040
defer server.TearDownFn()
4141

4242
client := clientset.NewForConfigOrDie(server.ClientConfig)

0 commit comments

Comments
 (0)