Skip to content

Commit 6aa3002

Browse files
committed
add kubeup label instead of a feature label
1 parent 9c56c5f commit 6aa3002

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

test/e2e/autoscaling/dns_autoscaling.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import (
2929
"k8s.io/apimachinery/pkg/labels"
3030
"k8s.io/apimachinery/pkg/util/wait"
3131
clientset "k8s.io/client-go/kubernetes"
32-
"k8s.io/kubernetes/test/e2e/feature"
3332
"k8s.io/kubernetes/test/e2e/framework"
3433
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
3534
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
@@ -106,7 +105,7 @@ var _ = SIGDescribe("DNS horizontal autoscaling", func() {
106105
// This test is separated because it is slow and need to run serially.
107106
// Will take around 5 minutes to run on a 4 nodes cluster.
108107
// TODO(upodroid) This test will be removed in 1.33 when kubeup is removed
109-
f.It(f.WithSerial(), f.WithSlow(), feature.KubeUp, "kube-dns-autoscaler should scale kube-dns pods when cluster size changed", func(ctx context.Context) {
108+
f.It(f.WithSerial(), f.WithSlow(), f.WithLabel("KubeUp"), "kube-dns-autoscaler should scale kube-dns pods when cluster size changed", func(ctx context.Context) {
110109
numNodes, err := e2enode.TotalRegistered(ctx, c)
111110
framework.ExpectNoError(err)
112111

test/e2e/cloud/gcp/restart.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ var _ = SIGDescribe("Restart", framework.WithDisruptive(), func() {
8888
}
8989
})
9090

91-
ginkgo.It("should restart all nodes and ensure all nodes and pods recover", func(ctx context.Context) {
91+
// TODO(upodroid) This test will be removed in 1.33 when kubeup is removed
92+
f.It(f.WithLabel("KubeUp"), "should restart all nodes and ensure all nodes and pods recover", func(ctx context.Context) {
9293
ginkgo.By("restarting all of the nodes")
9394
err := common.RestartNodes(f.ClientSet, originalNodes)
9495
framework.ExpectNoError(err)

test/e2e/feature/feature.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ var (
7171
KubeProxyDaemonSetDowngrade = framework.WithFeature(framework.ValidFeatures.Add("KubeProxyDaemonSetDowngrade"))
7272
KubeProxyDaemonSetUpgrade = framework.WithFeature(framework.ValidFeatures.Add("KubeProxyDaemonSetUpgrade"))
7373
KubeProxyDaemonSetMigration = framework.WithFeature(framework.ValidFeatures.Add("KubeProxyDaemonSetMigration"))
74-
KubeUp = framework.WithFeature(framework.ValidFeatures.Add("KubeUp"))
7574
LabelSelector = framework.WithFeature(framework.ValidFeatures.Add("LabelSelector"))
7675
LocalStorageCapacityIsolation = framework.WithFeature(framework.ValidFeatures.Add("LocalStorageCapacityIsolation"))
7776
LocalStorageCapacityIsolationQuota = framework.WithFeature(framework.ValidFeatures.Add("LocalStorageCapacityIsolationQuota"))

0 commit comments

Comments
 (0)