Merge pull request kubernetes#128484 from carlory/improve-error

k8s-ci-robot · web-flow · commit 6cb5ea56cb96 · 2024-11-03T02:19:27.000Z
improve error message format for WaitForPodSuccessInNamespaceTimeout
diff --git a/test/e2e/framework/pod/wait.go b/test/e2e/framework/pod/wait.go
@@ -475,7 +475,7 @@ func WaitForPodSuccessInNamespaceTimeout(ctx context.Context, c clientset.Interf
 			ginkgo.By("Saw pod success")
 			return true, nil
 		case v1.PodFailed:
-			return true, gomega.StopTrying(fmt.Sprintf("pod %q failed with status: %+v", podName, pod.Status))
+			return true, gomega.StopTrying(fmt.Sprintf("pod %q failed with status: \n%s", podName, format.Object(pod.Status, 1)))
 		default:
 			return false, nil
 		}

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ func WaitForPodSuccessInNamespaceTimeout(ctx context.Context, c clientset.Interf`
`475`	`475`	`ginkgo.By("Saw pod success")`
`476`	`476`	`return true, nil`
`477`	`477`	`case v1.PodFailed:`
`478`		`- return true, gomega.StopTrying(fmt.Sprintf("pod %q failed with status: %+v", podName, pod.Status))`
	`478`	`+ return true, gomega.StopTrying(fmt.Sprintf("pod %q failed with status: \n%s", podName, format.Object(pod.Status, 1)))`
`479`	`479`	`default:`
`480`	`480`	`return false, nil`
`481`	`481`	`}`