Skip to content

Commit 6fd8954

Browse files
author
Mengjiao Liu
committed
kube-controller-manager: also support context for record.NewBroadcaster
27a68ae introduced context support. In order to use that also with NewBroadcaster, a variant of the call is needed to allow the caller to specify the context.
1 parent 762dda5 commit 6fd8954

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

cmd/kube-controller-manager/app/controllermanager.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,16 @@ controller, and serviceaccounts controller.`,
132132
}
133133
cliflag.PrintFlags(cmd.Flags())
134134

135-
c, err := s.Config(KnownControllers(), ControllersDisabledByDefault(), ControllerAliases())
135+
ctx := context.Background()
136+
c, err := s.Config(ctx, KnownControllers(), ControllersDisabledByDefault(), ControllerAliases())
136137
if err != nil {
137138
return err
138139
}
139140

140141
// add feature enablement metrics
141142
fg := s.ComponentGlobalsRegistry.FeatureGateFor(featuregate.DefaultKubeComponent)
142143
fg.(featuregate.MutableFeatureGate).AddMetrics()
143-
return Run(context.Background(), c.Complete())
144+
return Run(ctx, c.Complete())
144145
},
145146
Args: func(cmd *cobra.Command, args []string) error {
146147
for _, arg := range args {

cmd/kube-controller-manager/app/options/options.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ limitations under the License.
1818
package options
1919

2020
import (
21+
"context"
2122
"fmt"
2223
"net"
2324

@@ -470,7 +471,7 @@ func (s *KubeControllerManagerOptions) Validate(allControllers []string, disable
470471
}
471472

472473
// Config return a controller manager config objective
473-
func (s KubeControllerManagerOptions) Config(allControllers []string, disabledByDefaultControllers []string, controllerAliases map[string]string) (*kubecontrollerconfig.Config, error) {
474+
func (s KubeControllerManagerOptions) Config(ctx context.Context, allControllers []string, disabledByDefaultControllers []string, controllerAliases map[string]string) (*kubecontrollerconfig.Config, error) {
474475
if err := s.Validate(allControllers, disabledByDefaultControllers, controllerAliases); err != nil {
475476
return nil, err
476477
}
@@ -494,7 +495,7 @@ func (s KubeControllerManagerOptions) Config(allControllers []string, disabledBy
494495
return nil, err
495496
}
496497

497-
eventBroadcaster := record.NewBroadcaster()
498+
eventBroadcaster := record.NewBroadcaster(record.WithContext(ctx))
498499
eventRecorder := eventBroadcaster.NewRecorder(clientgokubescheme.Scheme, v1.EventSource{Component: KubeControllerManagerUserAgent})
499500

500501
c := &kubecontrollerconfig.Config{

cmd/kube-controller-manager/app/testing/testserver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ func StartTestServer(ctx context.Context, customFlags []string) (result TestServ
113113
logger.Info("kube-controller-manager will listen securely", "port", s.SecureServing.BindPort)
114114
}
115115

116-
config, err := s.Config(all, disabled, aliases)
116+
config, err := s.Config(ctx, all, disabled, aliases)
117117
if err != nil {
118118
return result, fmt.Errorf("failed to create config from options: %v", err)
119119
}

0 commit comments

Comments
 (0)