Skip to content

Commit 71389d5

Browse files
authored
Merge pull request kubernetes#126920 from atiratree/statefulset-autodelete-pvc-rbac
add missing RBAC to statefulset-controller for StatefulSetAutoDeletePVC feature
2 parents fee426f + 55efd85 commit 71389d5

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

plugin/pkg/auth/authorizer/rbac/bootstrappolicy/controller_policy.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,13 +383,14 @@ func buildControllerRoles() ([]rbacv1.ClusterRole, []rbacv1.ClusterRoleBinding)
383383
rbacv1helpers.NewRule("update").Groups(appsGroup).Resources("statefulsets/finalizers").RuleOrDie(),
384384
rbacv1helpers.NewRule("get", "create", "delete", "update", "patch").Groups(legacyGroup).Resources("pods").RuleOrDie(),
385385
rbacv1helpers.NewRule("get", "create", "delete", "update", "patch", "list", "watch").Groups(appsGroup).Resources("controllerrevisions").RuleOrDie(),
386-
rbacv1helpers.NewRule("get", "create").Groups(legacyGroup).Resources("persistentvolumeclaims").RuleOrDie(),
386+
rbacv1helpers.NewRule("get", "create", "list", "watch").Groups(legacyGroup).Resources("persistentvolumeclaims").RuleOrDie(),
387387
eventsRule(),
388388
},
389389
}
390390

391391
if utilfeature.DefaultFeatureGate.Enabled(features.StatefulSetAutoDeletePVC) {
392392
role.Rules = append(role.Rules, rbacv1helpers.NewRule("update", "delete").Groups(legacyGroup).Resources("persistentvolumeclaims").RuleOrDie())
393+
role.Rules = append(role.Rules, rbacv1helpers.NewRule("update").Groups(legacyGroup).Resources("pods/finalizers").RuleOrDie())
393394
}
394395

395396
return role

plugin/pkg/auth/authorizer/rbac/bootstrappolicy/testdata/controller-roles.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1466,6 +1466,8 @@ items:
14661466
verbs:
14671467
- create
14681468
- get
1469+
- list
1470+
- watch
14691471
- apiGroups:
14701472
- ""
14711473
- events.k8s.io
@@ -1482,6 +1484,12 @@ items:
14821484
verbs:
14831485
- delete
14841486
- update
1487+
- apiGroups:
1488+
- ""
1489+
resources:
1490+
- pods/finalizers
1491+
verbs:
1492+
- update
14851493
- apiVersion: rbac.authorization.k8s.io/v1
14861494
kind: ClusterRole
14871495
metadata:

0 commit comments

Comments
 (0)