fix: Clarify allowed format for metric label overrides

yongruilin · yongruilin · commit 75386c82c8da · 2024-10-09T15:56:44.000-07:00
Clarify on the allowed format flag "--allow-metric-labels"
diff --git a/staging/src/k8s.io/component-base/metrics/options.go b/staging/src/k8s.io/component-base/metrics/options.go
@@ -129,7 +129,7 @@ func validateAllowMetricLabel(allowListMapping map[string]string) error {
 	for k := range allowListMapping {
 		reg := regexp.MustCompile(metricNameRegex + `,` + labelRegex)
 		if reg.FindString(k) != k {
-			return fmt.Errorf("--allow-metric-labels must have a list of kv pair with format `metricName:labelName=labelValue, labelValue,...`")
+			return fmt.Errorf("--allow-metric-labels must have a list of kv pair with format `metricName,labelName=labelValue, labelValue,...`")
 		}
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ func validateAllowMetricLabel(allowListMapping map[string]string) error {`
`129`	`129`	`for k := range allowListMapping {`
`130`	`130`	reg := regexp.MustCompile(metricNameRegex + `,` + labelRegex)
`131`	`131`	`if reg.FindString(k) != k {`
`132`		- return fmt.Errorf("--allow-metric-labels must have a list of kv pair with format `metricName:labelName=labelValue, labelValue,...`")
	`132`	+ return fmt.Errorf("--allow-metric-labels must have a list of kv pair with format `metricName,labelName=labelValue, labelValue,...`")
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`	`return nil`