Merge pull request kubernetes#129380 from jdtuhui/testifylint/len@component-base

k8s-ci-robot · web-flow · commit 7bfdda4696f7 · 2024-12-27T10:20:12.000+01:00
fix: enable len rule from testifylint in module component-base
diff --git a/staging/src/k8s.io/component-base/logs/json/json_test.go b/staging/src/k8s.io/component-base/logs/json/json_test.go
@@ -98,7 +98,7 @@ func TestZapLoggerInfo(t *testing.T) {
 
 		logStrLines := strings.Split(logStr, "\n")
 		dataFormatLines := strings.Split(data.format, "\n")
-		if !assert.Equal(t, len(logStrLines), len(dataFormatLines)) {
+		if !assert.Len(t, logStrLines, len(dataFormatLines)) {
 			t.Errorf("Info has wrong format: no. of lines in log is incorrect \n expect:%d\n got:%d", len(dataFormatLines), len(logStrLines))
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ func TestZapLoggerInfo(t *testing.T) {`
`98`	`98`
`99`	`99`	`logStrLines := strings.Split(logStr, "\n")`
`100`	`100`	`dataFormatLines := strings.Split(data.format, "\n")`
`101`		`- if !assert.Equal(t, len(logStrLines), len(dataFormatLines)) {`
	`101`	`+ if !assert.Len(t, logStrLines, len(dataFormatLines)) {`
`102`	`102`	`t.Errorf("Info has wrong format: no. of lines in log is incorrect \n expect:%d\n got:%d", len(dataFormatLines), len(logStrLines))`
`103`	`103`	`}`
`104`	`104`