Skip to content

Commit 7c3a9d6

Browse files
committed
Don't set default resize policy in E2E tests
1 parent da4dc0a commit 7c3a9d6

File tree

3 files changed

+0
-24
lines changed

3 files changed

+0
-24
lines changed

test/e2e/common/node/pod_resize.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -941,8 +941,6 @@ func doPodResizeTests(f *framework.Framework) {
941941
var pErr error
942942

943943
tStamp := strconv.Itoa(time.Now().Nanosecond())
944-
e2epod.InitDefaultResizePolicy(tc.containers)
945-
e2epod.InitDefaultResizePolicy(tc.expected)
946944
testPod = e2epod.MakePodWithResizableContainers(f.Namespace.Name, "", tStamp, tc.containers)
947945
testPod.GenerateName = "resize-test-"
948946
testPod = e2epod.MustMixinRestrictedPodSecurity(testPod)
@@ -1128,8 +1126,6 @@ func doPodResizeErrorTests(f *framework.Framework) {
11281126
var pErr error
11291127

11301128
tStamp := strconv.Itoa(time.Now().Nanosecond())
1131-
e2epod.InitDefaultResizePolicy(tc.containers)
1132-
e2epod.InitDefaultResizePolicy(tc.expected)
11331129
testPod = e2epod.MakePodWithResizableContainers(f.Namespace.Name, "testpod", tStamp, tc.containers)
11341130
testPod = e2epod.MustMixinRestrictedPodSecurity(testPod)
11351131

test/e2e/framework/pod/resize.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -142,21 +142,6 @@ func getTestResourceInfo(tcInfo ResizableContainerInfo) (res v1.ResourceRequirem
142142
return res, resizePol
143143
}
144144

145-
func InitDefaultResizePolicy(containers []ResizableContainerInfo) {
146-
noRestart := v1.NotRequired
147-
setDefaultPolicy := func(ci *ResizableContainerInfo) {
148-
if ci.CPUPolicy == nil {
149-
ci.CPUPolicy = &noRestart
150-
}
151-
if ci.MemPolicy == nil {
152-
ci.MemPolicy = &noRestart
153-
}
154-
}
155-
for i := range containers {
156-
setDefaultPolicy(&containers[i])
157-
}
158-
}
159-
160145
func makeResizableContainer(tcInfo ResizableContainerInfo) v1.Container {
161146
cmd := "grep Cpus_allowed_list /proc/self/status | cut -f2 && sleep 1d"
162147
res, resizePol := getTestResourceInfo(tcInfo)

test/e2e/node/pod_resize.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,6 @@ func doPodResizeAdmissionPluginsTests() {
138138
tc.enableAdmissionPlugin(ctx, f)
139139

140140
tStamp := strconv.Itoa(time.Now().Nanosecond())
141-
e2epod.InitDefaultResizePolicy(containers)
142-
e2epod.InitDefaultResizePolicy(expected)
143141
testPod1 := e2epod.MakePodWithResizableContainers(f.Namespace.Name, "testpod1", tStamp, containers)
144142
testPod1 = e2epod.MustMixinRestrictedPodSecurity(testPod1)
145143
testPod2 := e2epod.MakePodWithResizableContainers(f.Namespace.Name, "testpod2", tStamp, containers)
@@ -267,8 +265,6 @@ func doPodResizeSchedulerTests(f *framework.Framework) {
267265
}`, testPod2CPUQuantityResized.MilliValue(), testPod2CPUQuantityResized.MilliValue())
268266

269267
tStamp := strconv.Itoa(time.Now().Nanosecond())
270-
e2epod.InitDefaultResizePolicy(c1)
271-
e2epod.InitDefaultResizePolicy(c2)
272268
testPod1 := e2epod.MakePodWithResizableContainers(f.Namespace.Name, "testpod1", tStamp, c1)
273269
testPod1 = e2epod.MustMixinRestrictedPodSecurity(testPod1)
274270
testPod2 := e2epod.MakePodWithResizableContainers(f.Namespace.Name, "testpod2", tStamp, c2)
@@ -324,7 +320,6 @@ func doPodResizeSchedulerTests(f *framework.Framework) {
324320
}`, testPod1CPUQuantityResized.MilliValue(), testPod1CPUQuantityResized.MilliValue())
325321

326322
tStamp = strconv.Itoa(time.Now().Nanosecond())
327-
e2epod.InitDefaultResizePolicy(c3)
328323
testPod3 := e2epod.MakePodWithResizableContainers(f.Namespace.Name, "testpod3", tStamp, c3)
329324
testPod3 = e2epod.MustMixinRestrictedPodSecurity(testPod3)
330325
e2epod.SetNodeAffinity(&testPod3.Spec, node.Name)

0 commit comments

Comments
 (0)